test: Vitest v4 by colinaaa · Pull Request #2158 · lynx-family/lynx-stack

colinaaa · 2026-01-30T08:10:37Z

See: https://vitest.dev/guide/migration

@coderabbitai summary

Checklist

Tests updated (or not required).
Documentation updated (or not required).
Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

changeset-bot · 2026-01-30T08:10:41Z

🦋 Changeset detected

Latest commit: ff6b5dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lynx-js/testing-environment	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-30T08:10:48Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-01-30T08:14:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

See: https://vitest.dev/guide/migration.html#simplified-exclude

relativeci · 2026-01-30T08:36:39Z

Web Explorer

#7557 Bundle Size — 383.72KiB (0%).

ff6b5dc(current) vs bf1a177 main#7552(baseline)

Bundle metrics

1 change

	Current #7557	Baseline #7552
Initial JS	`154.88KiB`	`154.88KiB`
Initial CSS	`35.05KiB`	`35.05KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`8`	`8`
Modules	`237`(`-0.42%`)	`238`
Duplicate Modules	`16`	`16`
Duplicate Code	`2.99%`	`2.99%`
Packages	`4`	`4`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #7557	Baseline #7552
JS	`252.83KiB`	`252.83KiB`
Other	`95.85KiB`	`95.85KiB`
CSS	`35.05KiB`	`35.05KiB`

Bundle analysis report Branch colinaaa:colin/0130/vitest-v4 Project dashboard

^{Generated by RelativeCI Documentation Report issue}

``` × TS2468: Cannot find global value 'Promise'. File: ./src/__tests__/index.test.tsx:10:13 ```

``` TypeCheckError: No overload matches this call. The last overload gave the following error. Type 'Plugin<any>' is not assignable to type 'PluginOption'. Type 'import("/home/runner/_work/lynx-stack/lynx-stack/node_modules/.pnpm/rollup@4.57.0/node_modules/rollup/dist/rollup").Plugin<any>' is not assignable to type 'import("/home/runner/_work/lynx-stack/lynx-stack/node_modules/.pnpm/vite@7.3.1_@types+node@24.6.1_jiti@2.6.1_sass-embedded@1.90.0_sass@1.90.0_terser@5.31.6_yaml@2.8.1/node_modules/vite/dist/node/index", { with { "resolution-mode" "import" } }).Plugin<any>' with 'exactOptionalPropertyTypes true'. Consider adding 'undefined' to the types of the target's properties. Types of property 'resolveId' are incompatible. Type 'ObjectHook<(this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; importerAttributes? Record<string, string> | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>, { ...; }>' is not assignable to type 'ObjectHook<(this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; ssr? boolean | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>, { ...; }>'. Type '{ handler (this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; importerAttributes? Record<...> | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>; order? "pre" | ... 1 more ... | null; } & { ...; }' is not assignable to type 'ObjectHook<(this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; ssr? boolean | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>, { ...; }>'. Type '{ handler (this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; importerAttributes? Record<...> | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>; order? "pre" | ... 1 more ... | null; } & { ...; }' is not assignable to type '{ handler (this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; ssr? boolean | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>; order? "pre" | ... 1 more ... | null; } & { ...; }' with 'exactOptionalPropertyTypes true'. Consider adding 'undefined' to the types of the target's properties. Type '{ handler (this PluginContext, source string, importer string | undefined, options { attributes Record<string, string>; custom? CustomPluginOptions; importerAttributes? Record<...> | undefined; isEntry boolean; }) => ResolveIdResult | Promise<...>; order? "pre" | ... 1 more ... | null; } & { ...; }' is not assignable to type '{ filter? { id? StringFilter<RegExp>; }; }' with 'exactOptionalPropertyTypes true'. Consider adding 'undefined' to the types of the target's properties. The types of 'filter.id' are incompatible between these types. Type 'StringFilter<RegExp> | undefined' is not assignable to type 'StringFilter<RegExp>'. Type 'undefined' is not assignable to type 'StringFilter<RegExp>'. ❯ packages/rspeedy/plugin-config/vitest.config.ts:18:5 ```

.github/workflows/workflow-bench.yml

colinaaa · 2026-01-30T17:56:28Z

patches/@codspeed__vitest-plugin.patch

+       const runnerMode = getCodspeedRunnerMode();
+       const config = {
+         test: {
+          execArgv: getV8Flags(), // For Vitest v4


See CodSpeedHQ/codspeed-node#71

codspeed-hq · 2026-01-30T17:56:29Z

CodSpeed Performance Report

Merging this PR will degrade performance by 10.08%

_{Comparing colinaaa:colin/0130/vitest-v4 (ff6b5dc) with main (bf1a177)}

Summary

❌ 2 regressed benchmarks
✅ 61 untouched benchmarks
⏩ 3 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`basic-performance-nest-level-100`	6.9 ms	7.5 ms	-6.99%
❌	`transform 1000 view elements`	42.3 ms	47 ms	-10.08%

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

colinaaa · 2026-01-30T18:01:19Z

It looks like all the CI pipelines are passing except 100% coverage for react/*.

I'll adopt the experimentalAstAwareRemapping flag first in Vitest v3 before merging this PR to avoid making to much changes.

test: Vitest v4

43ed68f

colinaaa added 6 commits January 30, 2026 16:15

pnpm-lock

0a5500d

pnpm dedupe

e2701c6

test: rspeedy/core

24c0cf9

test: rspeedy/qrcode

c0dc9f1

test: v4 exclude

a02befe

See: https://vitest.dev/guide/migration.html#simplified-exclude

test: fix __dirname

ebb9887

colinaaa added 9 commits January 30, 2026 16:42

test: webpack/externals-loading

0031c40

test: react/runtime

6b62216

test: react/testing-library

19c87da

fix(react/testing-library): add transformMode: 'web'

b495533

chore: changeset

37407d3

fix: add lib ES2015

46726e9

``` × TS2468: Cannot find global value 'Promise'. File: ./src/__tests__/index.test.tsx:10:13 ```

ci: bump codspeed

f572598

test: type

2e4853d

github-advanced-security bot found potential problems Jan 30, 2026

View reviewed changes

.github/workflows/workflow-bench.yml Fixed Show fixed Hide fixed

.github/workflows/workflow-bench.yml Fixed Show fixed Hide fixed

colinaaa added 5 commits January 30, 2026 18:04

fix: lint

6600ea9

ci: bump codspeed

fdaaf2b

fix: type error

89d23cd

Patch @codspeed/vitest-plugin

0b376e3

Merge remote-tracking branch 'upstream/main' into colin/0130/vitest-v4

6fdf07a

colinaaa mentioned this pull request Jan 30, 2026

feat(vitest): support vitest v4 CodSpeedHQ/codspeed-node#71

Merged

colinaaa commented Jan 30, 2026

View reviewed changes

colinaaa added 2 commits February 9, 2026 11:34

Merge remote-tracking branch 'upstream/main' into colin/0130/vitest-v4

924cd3e

chore: bump codspeed vitest

ff6b5dc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Vitest v4#2158

test: Vitest v4#2158
colinaaa wants to merge 23 commits intolynx-family:mainfrom
colinaaa:colin/0130/vitest-v4

colinaaa commented Jan 30, 2026

Uh oh!

changeset-bot bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

Review skipped

Uh oh!

codecov bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

relativeci bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

colinaaa Jan 30, 2026

Uh oh!

codspeed-hq bot commented Jan 30, 2026 •

edited

Loading

Uh oh!

colinaaa commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

colinaaa commented Jan 30, 2026

Checklist

Uh oh!

changeset-bot bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

relativeci bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#7557 Bundle Size — 383.72KiB (0%).

Uh oh!

Uh oh!

Uh oh!

colinaaa Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will degrade performance by 10.08%

Summary

Performance Changes

Footnotes

Uh oh!

colinaaa commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Jan 30, 2026 •

edited

Loading

coderabbitai bot commented Jan 30, 2026 •

edited

Loading

codecov bot commented Jan 30, 2026 •

edited

Loading

relativeci bot commented Jan 30, 2026 •

edited

Loading

codspeed-hq bot commented Jan 30, 2026 •

edited

Loading