Skip to content

fix(gh-search): Add smart defaults and fix duplicate results #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prosdev merged 1 commit into from
Nov 24, 2025
Merged

fix(gh-search): Add smart defaults and fix duplicate results #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/cli/src/commands/gh.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ export const ghCommand = new Command('gh')
)
.addCommand(
new Command('search')
.description('Search GitHub issues and PRs')
.description('Search GitHub issues and PRs (defaults to open issues)')
.argument('<query>', 'Search query')
.option('--type <type>', 'Filter by type (issue, pull_request)')
.option('--state <state>', 'Filter by state (open, closed, merged)')
.option('--type <type>', 'Filter by type (default: issue)', 'issue')
.option('--state <state>', 'Filter by state (default: open)', 'open')
.option('--author <author>', 'Filter by author')
.option('--label <labels...>', 'Filter by labels')
.option('--limit <number>', 'Number of results', Number.parseInt, 10)
Expand Down Expand Up @@ -142,10 +142,10 @@ export const ghCommand = new Command('gh')

spinner.text = 'Searching...';

// Search
// Search with smart defaults (type: issue, state: open)
const results = await ghIndexer.search(query, {
type: options.type as 'issue' | 'pull_request' | undefined,
state: options.state as 'open' | 'closed' | 'merged' | undefined,
type: options.type as 'issue' | 'pull_request',
state: options.state as 'open' | 'closed' | 'merged',
author: options.author,
labels: options.label,
limit: options.limit,
Expand Down
6 changes: 6 additions & 0 deletions packages/subagents/src/github/indexer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,10 +177,16 @@ export class GitHubIndexer {

// Convert back to GitHubSearchResult format and apply filters
const results: GitHubSearchResult[] = [];
const seenIds = new Set<string>();

for (const result of vectorResults) {
const doc = JSON.parse(result.metadata.document as string) as GitHubDocument;

// Deduplicate by document ID
const docId = `${doc.type}-${doc.number}`;
if (seenIds.has(docId)) continue;
seenIds.add(docId);

// Apply filters
if (options.type && doc.type !== options.type) continue;
if (options.state && doc.state !== options.state) continue;
Expand Down