Cache globbed files for speed increase #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
A similar goal but with different implementation as #294 |
Contributor
Author
|
Also, the CI is failing due to Python 3.8 not being available to the "Set up Python" step. How much of this compatibility are you planing on maintaining? |
igli-t
approved these changes
Aug 8, 2025
lyz-code
approved these changes
Aug 11, 2025
Owner
lyz-code
left a comment
lyz-code
left a comment
There was a problem hiding this comment.
Thanks @fferegrino for the detailed PR.
We can safely drop 3.8 as it's deprecated for a while, we will be able to drop 3.9 soon too.
Can you please tweak the CI to include this change?
Contributor
Author
Sure, let me have a look. |
Contributor
Author
|
I've opened #299, hopefully this will get the tests rolling again. |
fferegrino
force-pushed
the
cache-glob-files
branch
from
9b10537 to
15e88a9
Compare
fferegrino
force-pushed
the
cache-glob-files
branch
from
6881812 to
c23dadc
Compare
It seems that the runners are slower
fferegrino
force-pushed
the
cache-glob-files
branch
from
c5f42b4 to
12d7822
Compare
Contributor
Author
|
Ok @lyz-code, this one seems good to be reviewed. |
Pull Request Test Coverage Report for Build 17473869987Details
💛 - Coveralls |
Owner
|
Thank you so much for contributing this feature and to clean up technical debt <3 |
Owner
|
Available since |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a glob caching mechanism to improve the performance of file discovery in the CLI, particularly for large directories and repeated glob operations. It also adds comprehensive tests to ensure correct cache behavior and performance gains.
tests/unit/test_cli_cache.pyto verify correct cache key construction, separation of entries, cache clearing, and correct results for bothglobandrgloboperations.tests/e2e/test_cli.pyto measure and assert performance improvements from caching, including a slow test to compare cached vs. uncached runs for exclude patterns.Checklist