Skip to content

Conversation

@wsnyder
Copy link
Contributor

@wsnyder wsnyder commented Dec 17, 2025

Fixes #282.

Checklist

  • Add test cases to all the changes you introduce
  • (N/A) Update the documentation for the changes

@wsnyder wsnyder force-pushed the bug282_hash branch 2 times, most recently from 2f3abb6 to a920e54 Compare December 17, 2025 00:07
@wsnyder
Copy link
Contributor Author

wsnyder commented Dec 17, 2025

The tests appear to fail due to a unrelated "make security" warning. It appears to pass tests standalone (on 3.12 - which I note you don't have CI testing).

@wsnyder
Copy link
Contributor Author

wsnyder commented Dec 17, 2025

Example of all actions passing on this pull, plus disabling make security: https://github.com/wsnyder/yamlfix/actions/runs/20287108569

@lyz-code
Copy link
Owner

Hi @wsnyder thank you for your contribution. As we're not checking the security of the repo right now, do you mind disabling that step in the CI?

That way future contributions will go smoother.

@wsnyder
Copy link
Contributor Author

wsnyder commented Dec 17, 2025

Ok, for security please consider/merge #306, then when done this one (which includes #306), thanks.

Once complete, I'd appreciate if you pushed a new version number so I can get it from pip. (I suspect you planned to anyways ;)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20303589788

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.016%

Totals Coverage Status
Change from base Build 18449692790: 0.0%
Covered Lines: 503
Relevant Lines: 508

💛 - Coveralls

@lyz-code lyz-code merged commit 67e00a9 into lyz-code:main Dec 18, 2025
4 checks passed
@wsnyder wsnyder deleted the bug282_hash branch December 18, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

# inside quote should be preseved

3 participants