Allow obtaining and restoring the streaming hashes' internal state. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a "very large stream" hashing use case: Instead of trying to read a large object in a single pass, one can fetch chunks of it at a time and save the state after each chunk as a checkpoint. In the case of a failure, the saved checkpoint can be used to retry from that point of the stream onwards.
|
Interesting feature. I can imagine its usefulness. Can I have a small sample code to try it out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables a "very large stream" hashing use case: Instead of trying to read a large remote object in a single pass, one can fetch chunks of it at a time and save the state after each chunk as a checkpoint. In the case of a failure, the saved checkpoint can be used to retry from that point of the stream onwards.
The state classes should be serializable by any json library. I did not add any annotations or such, to avoid polluting this library with extra dependencies.
I did not even try to implement this for the JNI versions. For my use case, the java implementations are sufficient, since for very large objects the limiting factor is not CPU, but download bandwidth.