Support: Scavenger Hunt on MHCT Map Helper (auto)#398
Draft
u-nel wants to merge 4 commits intom-h-c-t:mainfrom
Draft
Support: Scavenger Hunt on MHCT Map Helper (auto)#398u-nel wants to merge 4 commits intom-h-c-t:mainfrom
u-nel wants to merge 4 commits intom-h-c-t:mainfrom
Conversation
u-nel
force-pushed
the
feature-intake-scavenger-hunt-helper
branch
5 times, most recently
from
11d94c5 to
b47af66
Compare
Contributor
|
You'll need to limit the scope of the PR to just the map helper portion. I agree the incognito splitting needs to be fixed, but it needs to be in it's own PR because it could potentially have unknown side effects due to event messaging and other logic. It's been low priority since most users don't need to use the extension in incognito. Note on that code though, |
hymccord
reviewed
Jun 14, 2023
u-nel
force-pushed
the
feature-intake-scavenger-hunt-helper
branch
from
b47af66 to
faaf685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Implemented the suggested flow and code.
Thank you.