Merged
Conversation
This command is derived from `./data/generate_data.py` except that we do not configure the remote cache in here. This makes sense since the `iqb cache pull` already exists and uses parallel streams, so it is faster. Also, we now have commands with different responsibilities rather than having a single script with multiple responsibilities. As a follow up, we will clean the stuff we don't need anymore from the `./data` directory, which still contains scripts.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 99.41% 99.45% +0.03%
==========================================
Files 49 52 +3
Lines 3267 3480 +213
==========================================
+ Hits 3248 3461 +213
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This command is derived from
./data/generate_data.pyexcept that we do not configure the remote cache in here because theiqb cache pullalready exists and uses parallel streams, so it is faster. Also, we now have commands with different responsibilities rather than having a single script with multiple responsibilities.As a follow up, we will clean the stuff we don't need anymore from the
./datadirectory, which still contains scripts.While there, add to the manifest new files produced testing this code.