feat: Updated map to display regions #144
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 52 52
Lines 3729 3729
=======================================
Hits 3726 3726
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bassosimone @sermpezis FYI on moving sandbox code to main application |
|
@zarsl I will take a look |
bassosimone
left a comment
bassosimone
left a comment
There was a problem hiding this comment.
Thanks, I'm going to merge this now! 🐳
|
|
||
| GEOJSON_ADMIN1_DIR = SCRIPT_DIR.parent / "natural_earth" / "geojson_admin1" | ||
| MANIFEST_URL = ( | ||
| "https://raw.githubusercontent.com/m-lab/iqb/main/data/state/ghremote/manifest.json" |
There was a problem hiding this comment.
Note to self. We should probably pin or include this into the distribution. Fetching directly from main could cause side effects. Need to think a bit more about the right approach here.
There was a problem hiding this comment.
OK, after my recent changes, we have this error:
ImportError: cannot import name 'IQBGitHubRemoteCache' from 'iqb.ghremote.cache' (/app/library/src/iqb/ghremote/cache.py)
Traceback:
File "/app/prototype/pages/IQB_Map.py", line 24, in <module>
from iqb.ghremote.cache import IQBGitHubRemoteCache, Manifest, data_dir_or_default
It should not be a huge deal, however the name has changed. The new name is IQBRemoteCache. The pull request that caused a breaking change is #131.
There was a problem hiding this comment.
Fixed in fc3b142. Now I am going to wait for the deployment and check the online prototype again. (Curiously tests were passing and I guess this is part of the "this is a prototype package". We -- for values of "we" close to "me" -- need to pay attention when refactoring, since green does not automatically imply that it's all good. 😅 In the next iteration, we probably want to improve the amount of testing of the prototype, now that the code has settled and it's probably a better moment to introduce more tests.)
There was a problem hiding this comment.
OK, confirmed that the prototype is WAI again.
3 participants
This pull request includes the latest IQB-prototype changes and specifically a better map.