Merged
Conversation
This commit implements the IQBCache component for fetching IQB measurement data from local cache files. Key features: 1. Git-like .iqb/ directory convention (customizable) 2. Support for US, DE, BR data (October 2024) 3. Percentile extraction (1-99) with helpful error messages 4. Good test coverage (13 tests) We adopt a convention where .iqb/ is the default cache directory in the current working directory (like .git/), but this can be overridden by passing a custom path. While there, we address these additional quality improvements: 1. Add .editorconfig for cross-editor consistency 2. Add explicit ruff formatting rules (spaces, double quotes, LF) 3. Add ruff format/lint/pyright checks to CI pipeline
bassosimone
force-pushed
the
feat/cache
branch
from
cba4edc to
f6f7a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements the IQBCache component for fetching IQB measurement data from local cache files.
Key features:
Git-like .iqb/ directory convention (customizable)
Support for US, DE, BR data (October 2024)
Percentile extraction (1-99) with helpful error messages
Good test coverage (13 tests)
We adopt a convention where .iqb/ is the default cache directory in the current working directory (like .git/), but this can be overridden by passing a custom path.
While there, we address these additional quality improvements:
Add .editorconfig for cross-editor consistency
Add explicit ruff formatting rules (spaces, double quotes, LF)
Add ruff format/lint/pyright checks to CI pipeline
I have some doubts regarding how we're using percentiles. I will address them in a subsequent pull request and then ask for a review, because that matter seems to require discussion, while this pull request is more mechanical.