refactor: streamline local aggregation design#20
Merged
bassosimone merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
Extracted provider-specific data loading into separate methods (_get_mlab_data, etc.) with get_data() acting as orchestrator that glues provider data together at access time. This "separate pipelines, aggregate at access" approach scales well incrementally (Phase 3 just adds _get_cloudflare_data() and _get_ookla_data() calls) and is cheap since data is small regardless of time window. Added design note documenting rationale and left TODO about partial data policy (should M-Lab be required while Cloudflare/Ookla optional?). What started as a tiny TODO documenting a hack became a documented feature about how we're evolving the pipeline. Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted provider-specific data loading into separate methods (_get_mlab_data, etc.) with get_data() acting as orchestrator that glues provider data together at access time.
This "separate pipelines, aggregate at access" approach scales well incrementally (Phase 3 just adds _get_cloudflare_data() and _get_ookla_data() calls) and is cheap since data is small regardless of time window.
Added design note documenting rationale and left TODO about partial data policy (should M-Lab be required while Cloudflare/Ookla optional?).
What started as a tiny TODO documenting a hack became a documented feature about how we're evolving the pipeline. Nice!