Open
Conversation
MikuroXina
force-pushed
the
fix-warnings
branch
2 times, most recently
from
4677f01 to
249dffc
Compare
And fix warnings
Fix indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ビルドしてみたところ, 正常にビルドできるもののいくつかのコードに対してコンパイラーが警告を出したため, それらを修正してみました.
returnしない分岐を修正TextSliderのpivotにNULLではなくoptionalを利用して任意引数を表現するように修正splitの実行結果を範囲forでループさせている箇所での不要なコピーを抑制size_tに置換