Skip to content

docs: enhance documentation for Builder and error handling functions #32

Merged
m-mizutani merged 1 commit intomainfrom
chore/improve-godoc-documentation
Sep 17, 2025
Merged

docs: enhance documentation for Builder and error handling functions #32
m-mizutani merged 1 commit intomainfrom
chore/improve-godoc-documentation

Conversation

@m-mizutani
Copy link
Owner

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @m-mizutani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation and provides practical examples for key functionalities within the goerr library. The changes aim to improve developer understanding and adoption of features like the Builder pattern for shared error context, the ID function for robust error comparison, and type-safe keys for attaching structured data to errors. By clarifying existing godocs and adding illustrative examples, the PR makes the error handling mechanisms more intuitive and easier to use.

Highlights

  • Enhanced Documentation for NewBuilder: The godoc for NewBuilder has been expanded to clearly explain its utility in creating multiple errors that share a common context, such as a request ID or service name, without repetitive option specification.
  • Clarified ID and With Function Documentation: The documentation for the ID function now better explains how it enables errors.Is() to compare errors by their ID string, facilitating sentinel-like error matching. The With function's godoc has also been improved to detail its use case for enriching errors in middleware and how it handles both *goerr.Error and standard errors.
  • Updated Deprecation Message for WithTags: The Deprecated comment for the WithTags method has been updated to explicitly guide users to use the goerr.Tag option with goerr.New() or goerr.Wrap() as the preferred alternative.
  • New Example for NewBuilder: An ExampleNewBuilder function has been added to builder_test.go, demonstrating how to effectively use the builder pattern to attach common contextual values to multiple errors.
  • New Example for ID Function: An ExampleID function has been added to error_test.go, illustrating how to define an error with an ID and subsequently use errors.Is() for robust error type checking.
  • New Example for NewTypedKey: An ExampleNewTypedKey function has been added to typed_values_test.go, showcasing the definition and usage of type-safe keys (UserIDKey, RequestIDKey) with goerr.TV() and goerr.GetTypedValue() for compile-time safety.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides excellent enhancements to the documentation and examples for the library. The updated comments for NewBuilder, ID, With, WithTags, and NewTypedKey are much clearer and more descriptive. The addition of Example functions for NewBuilder, ID, and NewTypedKey is a great way to provide runnable documentation and demonstrate the library's features effectively. All changes are well-implemented and improve the overall quality and usability of the project.

@m-mizutani m-mizutani merged commit 37ce5a8 into main Sep 17, 2025
5 checks passed
@m-mizutani m-mizutani deleted the chore/improve-godoc-documentation branch September 17, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant