Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@peekjef72
Copy link

@peekjef72 peekjef72 commented Oct 24, 2020

Pull Request Template

Description

  • Add interface to health grafana info (/api/heath)
  • Add new method on datasource get_datasource_proxy_data (/api/datasource/proxy...)
    to be able to collect data info through grafana.

All the features are required for a tool to build real grafana-snapshots containing data.

Have you written tests?

  • Yes
  • No
    => no specific tests but, I use the new features for a tool using grafana_api, that will be soon on github (grafana-snapshots)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@peekjef72 peekjef72 requested a review from m0nhawk as a code owner October 24, 2020 13:00
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@d2e1520). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage        ?   84.88%           
=======================================
  Files           ?       17           
  Lines           ?      655           
  Branches        ?        0           
=======================================
  Hits            ?      556           
  Misses          ?       99           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e1520...281f5ae. Read the comment docs.

@peekjef72 peekjef72 changed the title Add interface to health and method to datasources (poxy-data) Add interface to health and method to datasources (proxy-data) Oct 24, 2020
@lodgvideon
Copy link

Any Updates? When it will be merged?

@peekjef72
Copy link
Author

Sorry but what is required in fact for that PR to be merged, in practice ?
I'm probably stupid, but really can't find what to do...

@amotl
Copy link

amotl commented Feb 6, 2022

Hi there,

we just integrated this patch into the grafana-client-fork (see #88) on behalf of grafana-toolbox/grafana-client#5. Thank you very much, @peekjef72!

With kind regards,
Andreas.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants