Update cloudfail.py for Python 3.8.5 #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudfail.py:177: DeprecationWarning: please use dns.resolver.Resolver.resolve() instead # Changed query() to resolve() cloudfail.py:180: SyntaxWarning: "is not" with a literal. Did you mean "!="? while choice is not 'y' and choice is not 'n': cloudfail.py:180: SyntaxWarning: "is not" with a literal. Did you mean "!="? while choice is not 'y' and choice is not 'n': cloudfail.py:182: SyntaxWarning: "is" with a literal. Did you mean "=="? if choice is 'y': # Changed the above "is not" to != and "is" to == Don't have a wildcarded cloudflare domain to check, but doesn't generate any further warnings
|
Independently confirmed to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #27 running under Python 3.8.5 on Ubuntu 20.04.1 LTS
cloudfail.py:177: DeprecationWarning: please use dns.resolver.Resolver.resolve() instead
Changed query() to resolve()
cloudfail.py:180: SyntaxWarning: "is not" with a literal. Did you mean "!="?
while choice is not 'y' and choice is not 'n':
cloudfail.py:180: SyntaxWarning: "is not" with a literal. Did you mean "!="?
while choice is not 'y' and choice is not 'n':
cloudfail.py:182: SyntaxWarning: "is" with a literal. Did you mean "=="?
if choice is 'y':
Changed the above "is not" to != and "is" to ==
Don't have a wildcarded cloudflare domain to check, but doesn't generate any further warnings