fix(mutable/ordered): panic on iterating over empty Set

Author: m4gshm

collection/mutable/ordered/set.go

@@ -36,14 +36,18 @@ var (
 // All is used to iterate through the collection using `for e := range`.
 func (s *Set[T]) All(consumer func(T) bool) {
 	if s != nil {
-		slice.WalkWhile(*s.order, consumer)
+		if order := s.order; order != nil {
+			slice.WalkWhile(*order, consumer)
+		}
 	}
 }
 
 // IAll is used to iterate through the collection using `for i, e := range`.
 func (s *Set[T]) IAll(consumer func(int, T) bool) {
 	if s != nil {
-		slice.TrackWhile(*s.order, consumer)
+		if order := s.order; order != nil {
+			slice.TrackWhile(*order, consumer)
+		}
 	}
 }
 

collection/mutable/ordered/set/test/set_test.go

@@ -136,6 +136,20 @@ func Test_Set_Nil(t *testing.T) {
 	assert.False(t, ok)
 }
 
+func Test_Set_Empty_All(t *testing.T) {
+	set := &ordered.Set[int]{}
+	assert.Equal(t, 0, len(seq.Slice(set.All)))
+}
+
+func Test_Set_Empty_IAll(t *testing.T) {
+	set := &ordered.Set[int]{}
+	out := []int{}
+	for _, v := range set.IAll {
+		out = append(out, v)
+	}
+	assert.Equal(t, 0, len(out))
+}
+
 func Test_Set_Zero(t *testing.T) {
 	var mset ordered.Set[int]
 	var nils []int

collection/mutable/vector/test/vector_test.go

@@ -26,6 +26,26 @@ func Test_VectorIterate(t *testing.T) {
 	assert.Equal(t, expected, result)
 }
 
+func Test_Vector_Empty_IAll(t *testing.T) {
+	expected := []int{}
+	v := &mutable.Vector[int]{}
+	result := make([]int, v.Len())
+	for  _, it := range v.IAll {
+		result = append(result, it)
+	}
+	assert.Equal(t, expected, result)
+}
+
+func Test_Vector_Empty_All(t *testing.T) {
+	expected := []int{}
+	v := &mutable.Vector[int]{}
+	result := make([]int, v.Len())
+	for it := range v.All {
+		result = append(result, it)
+	}
+	assert.Equal(t, expected, result)
+}
+
 func Test_VectorIterateOverRange(t *testing.T) {
 	expected := slice.Of(1, 2, 3, 4)
 	v := vector.Of(1, 2, 3, 4)