Skip to content

SpreadsheetMetadataDefaultTextResource.scriptingConverter added "stor… #8633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mP1 merged 1 commit into from
Feb 2, 2026
+24 −6
Merged

SpreadsheetMetadataDefaultTextResource.scriptingConverter added "stor… #8633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/main/java/walkingkooka/spreadsheet/convert/provider/MissingConverterVerifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,20 @@ static Set<MissingConverter> verify(final Converter<SpreadsheetConverterContext>
);
}

if (scripting) {
final StoragePath storagePathWithout = StoragePath.parse("/path1/file2");
final StoragePath storagePathJson = StoragePath.parse("/path1/file2.json");

verifier.addIfConversionFail(
Lists.of(
storagePathWithout,
storagePathJson
),
Class.class,
SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS
);
}

// text-to-error............................................................................................
if (validation) {
verifier.addIfConversionFail(
Expand Down
6 changes: 5 additions & 1 deletion ...va/walkingkooka/spreadsheet/convert/provider/SpreadsheetConvertersConverterProviders.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public final class SpreadsheetConvertersConverterProviders implements PublicStat
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.COLOR_TO_NUMBER)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.NUMBER_TO_COLOR)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_STORAGE_PATH)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_FORM_NAME)
Expand All @@ -60,6 +60,7 @@ public final class SpreadsheetConvertersConverterProviders implements PublicStat

public final static ConverterAliasSet FORMATTING = ALL.aliasSet()
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_FORM_NAME)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_VALIDATION_ERROR);
Expand All @@ -69,6 +70,7 @@ public final class SpreadsheetConvertersConverterProviders implements PublicStat
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.COLOR_TO_NUMBER)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.NUMBER_TO_COLOR)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_FORM_NAME)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_STORAGE_PATH)
Expand All @@ -85,6 +87,7 @@ public final class SpreadsheetConvertersConverterProviders implements PublicStat
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.HAS_TEXT_NODE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.NUMBER_TO_COLOR)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_ERROR)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_FORM_NAME)
Expand All @@ -102,6 +105,7 @@ public final class SpreadsheetConvertersConverterProviders implements PublicStat
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.HAS_TEXT_NODE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.NUMBER_TO_COLOR)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_PATH_JSON_TO_CLASS)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.STORAGE_VALUE_INFO_LIST_TO_TEXT)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_STORAGE_PATH)
.deleteAliasOrName(SpreadsheetConvertersConverterProvider.TEXT_TO_TEXT_STYLE_PROPERTY_NAME)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataDefaultTextResource.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"plugins": "",
"precision": 10,
"roundingMode": "HALF_UP",
"scriptingConverter": "collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, style, text-node, text-to-line-ending, template, net)",
"scriptingConverter": "collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, storage-path-json-to-class, style, text-node, text-to-line-ending, template, net)",
"showFormulaEditor": true,
"showFormulas": false,
"showGridLines": true,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/walkingkooka/spreadsheet/meta/SpreadsheetMetadataTesting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ public Optional<EmailAddress> user() {
RoundingMode.HALF_UP
).set(
SpreadsheetMetadataPropertyName.SCRIPTING_CONVERTER,
ConverterSelector.parse("collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, style, text-node, text-to-line-ending, template, net)"
ConverterSelector.parse("collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, storage-path-json-to-class, style, text-node, text-to-line-ending, template, net)"
)
).set(
SpreadsheetMetadataPropertyName.SCRIPTING_FUNCTIONS,
Expand Down
4 changes: 2 additions & 2 deletions ...walkingkooka/spreadsheet/engine/SpreadsheetEngineContextSharedSpreadsheetContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1329,7 +1329,7 @@ public void testToString() {
" \"plugins\": \"\",\n" +
" \"precision\": 10,\n" +
" \"roundingMode\": \"HALF_UP\",\n" +
" \"scriptingConverter\": \"collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, style, text-node, text-to-line-ending, template, net)\",\n" +
" \"scriptingConverter\": \"collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, storage-path-json-to-class, style, text-node, text-to-line-ending, template, net)\",\n" +
" \"showFormulaEditor\": true,\n" +
" \"showFormulas\": false,\n" +
" \"showGridLines\": true,\n" +
Expand Down Expand Up @@ -1554,7 +1554,7 @@ public void testToStringMetadataIncludingAllColorNameAndColorNumberProperties()
" \"plugins\": \"\",\n" +
" \"precision\": 10,\n" +
" \"roundingMode\": \"HALF_UP\",\n" +
" \"scriptingConverter\": \"collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, style, text-node, text-to-line-ending, template, net)\",\n" +
" \"scriptingConverter\": \"collection(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, storage-path-json-to-class, style, text-node, text-to-line-ending, template, net)\",\n" +
" \"showFormulaEditor\": true,\n" +
" \"showFormulas\": false,\n" +
" \"showGridLines\": true,\n" +
Expand Down
2 changes: 1 addition & 1 deletion ...a/walkingkooka/spreadsheet/meta/SpreadsheetMetadataSpreadsheetEnvironmentContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ public void testTreePrint() {
" HALF_UP\n" +
" scriptingConverter\n" +
" collection\n" +
" \"(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, style, text-node, text-to-line-ending, template, net)\"\n" +
" \"(text, number, date-time, basic, spreadsheet-value, boolean, error-throwing, color, expression, environment, json, locale, plugins, spreadsheet-metadata, storage, storage-path-json-to-class, style, text-node, text-to-line-ending, template, net)\"\n" +
" scriptingFunctions\n" +
" serverUrl\n" +
" https://example.com (walkingkooka.net.AbsoluteUrl)\n" +
Expand Down
Loading