ci: Add CI build of React Native #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonStalnaker
force-pushed
the
ci/6928-Add-CI-Build-of-RN
branch
from
38bab9f to
5504c7d
Compare
einsteinx2
suggested changes
Nov 22, 2024
| on: [pull_request] | ||
|
|
||
| jobs: | ||
| # pod-lint: |
Contributor
There was a problem hiding this comment.
Please remove all the commented out stuff in this file
.gitignore
Outdated
| *.stackdump | ||
|
|
||
| # ReactCommon subdir shouldn't have Xcode project | ||
| /packages/react-native/ReactCommon/**/*.xcodeproj |
Contributor
There was a problem hiding this comment.
Can we just gitignore the entire /packages directory? I assume these packages and their exact directories may change in the future. Also is there any need to include other things from /packages ever?
| @@ -0,0 +1,10 @@ | |||
| # Add project specific ProGuard rules here. | |||
Contributor
There was a problem hiding this comment.
Is it possible to remove the Android part of this example project entirely? I know by default it creates both, but it should be possible to make an iOS only RN project.
einsteinx2
approved these changes
Nov 27, 2024
Contributor
|
🎉 This PR is included in version 8.27.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)