Skip to content

refactor: Update MPResponseConfig to Swift #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrandonStalnaker merged 9 commits into from
Dec 10, 2024
Merged

refactor: Update MPResponseConfig to Swift #316

BrandonStalnaker merged 9 commits into from
Dec 10, 2024

Conversation

@BrandonStalnaker
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker commented Dec 5, 2024

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Refactor MPResponseConfig to Swift

Testing Plan

  • Tested in sample app and confirmed all unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Dec 5, 2024
einsteinx2
einsteinx2 suggested changes Dec 10, 2024
View reviewed changes
einsteinx2
einsteinx2 suggested changes Dec 10, 2024
View reviewed changes
@BrandonStalnaker BrandonStalnaker force-pushed the refactor/SQDSDKS-6827-Refactor-MPResponseConfig-to-Swift branch from 621088d to d8321e5 Compare December 10, 2024 18:47
@BrandonStalnaker BrandonStalnaker force-pushed the refactor/SQDSDKS-6827-Refactor-MPResponseConfig-to-Swift branch from d8321e5 to eb9dc77 Compare December 10, 2024 20:14
@BrandonStalnaker BrandonStalnaker force-pushed the refactor/SQDSDKS-6827-Refactor-MPResponseConfig-to-Swift branch from a33715a to 011f655 Compare December 10, 2024 21:01
@BrandonStalnaker BrandonStalnaker merged commit 07c96ca into refactor/blackout Dec 10, 2024
11 of 12 checks passed
@BrandonStalnaker BrandonStalnaker deleted the refactor/SQDSDKS-6827-Refactor-MPResponseConfig-to-Swift branch December 10, 2024 21:19
BrandonStalnaker added a commit that referenced this pull request Jan 28, 2025
@BrandonStalnaker
refactor: Update MPResponseConfig to Swift (#316)
441dcc6 
* refactor: Make MPStateMachine Public
einsteinx2 pushed a commit that referenced this pull request Jan 28, 2025
@BrandonStalnaker @einsteinx2
refactor: Update MPResponseConfig to Swift (#316)
3521f0a 
* refactor: Make MPStateMachine Public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@einsteinx2 einsteinx2 einsteinx2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BrandonStalnaker BrandonStalnaker

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrandonStalnaker @einsteinx2