refactor: Port MParticleWebView to Swift #319
Conversation
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Just a few questions
| XCTAssertEqualObjects(_webView.originalDefaultAgent, defaultAgent); | ||
| } | ||
|
|
||
| - (void)testBackgroundCollection { |
There was a problem hiding this comment.
Was this test and the other removed for any particular reason? I'm not against it as they seem to be more testing mocking and Apple code but I'm curious if that's your reson
There was a problem hiding this comment.
Yesh, so the 2 tests I removed were because OCMock wasn't properly detecting the call of the method (the "expect") even though it was 100% being called, confirmed via breakpoints. Seems to be some incompatibility with OCMock and Swift. In any case, when I looked closer at what was really being tested, it was just testing that a method was called that is literally always called, it wasn't really testing the logic.
Basically on iOS evaluateAgent is always called after calling startWithCustomUserAgent and on tvOS it never is, so this and the other test I removed ultimately were just testing that the #if os(iOS) worked, which isn't really useful.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)