refactor: Port MPDevice to Swift #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonStalnaker
force-pushed
the
refactor/7023-Swift-port-MPDevice
branch
5 times, most recently
from
8aa315a to
dc6f9df
Compare
BrandonStalnaker
force-pushed
the
refactor/7023-Swift-port-MPDevice
branch
from
dc6f9df to
84b6014
Compare
Contributor
|
I don't have access to approve, but reviewed over Zoom and this looks good to go. |
Mansi-mParticle
approved these changes
Feb 11, 2025
Contributor
Mansi-mParticle
left a comment
Mansi-mParticle
left a comment
There was a problem hiding this comment.
Ben has already reviewed this code via zoom call , so it's now approved.
Contributor
|
🎉 This PR is included in version 8.27.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)