fix: Issue when setting Identity Attributes to nil#336
Merged
BrandonStalnaker merged 1 commit intodevelopmentfrom Mar 18, 2025
Merged
Conversation
rmi22186
approved these changes
Mar 18, 2025
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
LGTM - Hopped on with Brandon to E2E test using old code to repro the issue, then using the new code, the sdk does not crash because Swift gets a nil value instead of NSNull
BrandonStalnaker
deleted the
fix/SQDSDKS-7144-Error-On-Setting-Identity-To-Nil
branch
mparticle-automation
added a commit
that referenced
this pull request
Mar 19, 2025
Contributor
|
🎉 This PR is included in version 8.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)