feat: Add Rokt First Party Kit Support#339
Merged
BrandonStalnaker merged 7 commits intodevelopmentfrom Apr 2, 2025
Merged
Conversation
BrandonStalnaker
force-pushed
the
feat/SQDSDKS-7156-Add-Rokt-First-Party-Kit-Support
branch
from
d808c5c to
43618c4
Compare
rmi22186
reviewed
Apr 1, 2025
| - (nonnull MPKitExecStatus *)executeWithViewName:(NSString * _Nullable)viewName | ||
| attributes:(NSDictionary<NSString *, NSString *> * _Nonnull)attributes | ||
| placements:(NSDictionary<NSString *, id> * _Nullable)placements | ||
| onLoad:(void (^ _Nullable)(void))onLoad onUnLoad:(void (^ _Nullable)(void))onUnLoad |
Member
There was a problem hiding this comment.
onUnLoad should be on the next line
rmi22186
requested changes
Apr 1, 2025
mParticle-Apple-SDK/mParticle.m
Outdated
| }); | ||
| } | ||
|
|
||
| + (NSDictionary<NSString *, NSString *> *) mapUserAttributes:(NSDictionary<NSString *, NSString *> * _Nonnull)attributes mappingDictionary:(NSDictionary<NSString *, NSString *> *)mappingDictionary { |
Collaborator
Author
There was a problem hiding this comment.
rarely do we colon align with only 2 parameters but I do agree it looks nice so 🤷
BrandonStalnaker
commented
Apr 1, 2025
BrandonStalnaker
commented
Apr 1, 2025
BrandonStalnaker
force-pushed
the
feat/SQDSDKS-7156-Add-Rokt-First-Party-Kit-Support
branch
from
e702cdc to
5785e39
Compare
rmi22186
approved these changes
Apr 1, 2025
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
LGTM! just 1 pending comment for @danial-rokt
rmi22186
approved these changes
Apr 2, 2025
BrandonStalnaker
deleted the
feat/SQDSDKS-7156-Add-Rokt-First-Party-Kit-Support
branch
mparticle-automation
added a commit
that referenced
this pull request
Apr 2, 2025
# [8.29.0](v8.28.1...v8.29.0) (2025-04-02) ### Features * Add Rokt First Party Kit Support ([#339](#339)) ([9bb2e2d](9bb2e2d))
Contributor
|
🎉 This PR is included in version 8.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
executeWithViewNamemethod that call down into the Rokt sdk through the Rokt kit integrationsTesting Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)