Skip to content

Conversation

@BrandonStalnaker
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker commented Aug 7, 2025

Summary

  • While namespacing is not a concern when developing with Frameworks in Swift or Objective C in isolation it can cause issues in Objective C frameworks like NSSecureCoding when bridging from Swift. By adding the annotation @objc(name), namespacing is ignored even if we are working with Swift.

Here's the latest error message the client was running into

[21:45:29]: ▸ Testing failed:
[21:45:29]: ▸ 'MPLocationManager_PRIVATE' has different definitions in different modules; first difference is definition in module 'mParticle_Apple_SDK_NoLocation.Swift' found method
[21:45:29]: ▸ 'MPDevice' has different definitions in different modules; first difference is definition in module 'mParticle_Apple_SDK.Swift' found property 'carrier'
[21:45:29]: ▸ Command SwiftCompile failed with a nonzero exit code
[21:45:29]: ▸ ** TEST FAILED **

Testing Plan

  • Was this tested locally? If not, explain why.
  • Confirmed functionality in sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Aug 7, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner August 7, 2025 17:24
@BrandonStalnaker BrandonStalnaker force-pushed the fix/SQDSDKS-7527-Prevent-Namespacing-for-Encoded-Objects branch from cf01659 to 6015a1d Compare August 7, 2025 18:45
@BrandonStalnaker BrandonStalnaker merged commit b83480e into development Aug 8, 2025
15 of 16 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/SQDSDKS-7527-Prevent-Namespacing-for-Encoded-Objects branch August 8, 2025 13:40
mparticle-automation added a commit that referenced this pull request Aug 8, 2025
## [8.37.1](v8.37.0...v8.37.1) (2025-08-08)

### Bug Fixes

* Prevent Swift Name Spacing for Encodable Objects ([#385](#385)) ([b83480e](b83480e))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.37.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants