Skip to content

Conversation

@denischilik
Copy link
Contributor

Summary

  • This PR contains two script files check_coverage.sh and check_coverage.py to build project coverage report
  • To build report you can run check_coverage.sh from build folder.
  • check_coverage.py contains COVERAGE_THRESHOLD which is used to highlight files with red if coverage less the threshold.
  • Script doesn't display files which have 100% coverage

Testing Plan

  • [*] Was this tested locally? If not, explain why.
  • to check project test coverage you can run check_coverage.sh from build folder.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, discussed in-person with walkthrough and everything works as expected.

@BrandonStalnaker
Copy link
Collaborator

BrandonStalnaker commented Aug 13, 2025

@jamesnrokt and @rmi22186 The implementation here is solid but if we'd prefer to use codeCov it doesn't make much sense to merge this. Should we schedule a meeting to decide this or have we already landed on one or the other?

More info from Denis on this where he compared the 2
https://docs.google.com/document/d/1mMxgIQwrE3vyQC6ZFGDi0F1BYd9BO9Jf_lk_0H-lKK4/edit?usp=sharing

@denischilik
Copy link
Contributor Author

denischilik commented Aug 13, 2025

@jamesnrokt and @rmi22186 The implementation here is solid but if we'd prefer to use codeCov it doesn't make much sense to merge this. Should we schedule a meeting to decide this or have we already landed on one or the other?

Will you guys have chance to sync tomorrow?
I’ve sent an invite for a quick call.

@rmi22186
Copy link
Member

My understanding is the current script in this PR is primarily for local development feedback to ensure PRs have a certain level of code coverage before pushing the branch up. Whereas codecov could be used to fail CI/CD if a certain level of code coverage is not attained. Is that accurate @denischilik

@denischilik
Copy link
Contributor Author

denischilik commented Aug 14, 2025 via email

@denischilik denischilik merged commit eaee66e into development Aug 14, 2025
42 of 57 checks passed
@jamesnrokt jamesnrokt deleted the feat/test-coverage-scripts-updated branch August 17, 2025 23:54
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants