Skip to content

feat: Map Selected Identity to Emailsha256 #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrandonStalnaker merged 1 commit into from
Aug 20, 2025
Merged

feat: Map Selected Identity to Emailsha256 #391

BrandonStalnaker merged 1 commit into from
Aug 20, 2025

Conversation

@BrandonStalnaker
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker commented Aug 18, 2025

Summary

  • Updated the logic to use the selected identity as the emailsha256 identity for Rokt. Defaults to 'other' in case this were to go live before the backend change.

Testing Plan

  • Was this tested locally? If not, explain why.
  • Unit tests and through sample app

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Aug 18, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner August 18, 2025 19:48
@BrandonStalnaker BrandonStalnaker force-pushed the feat/SQDSDKS-7628-Map-Selected-Identity-to-Emailsha256 branch from a59b05c to ada97e1 Compare August 18, 2025 19:53
nickolas-dimitrakas
nickolas-dimitrakas approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit a14544b into development Aug 20, 2025
22 of 28 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/SQDSDKS-7628-Map-Selected-Identity-to-Emailsha256 branch August 20, 2025 17:06
mparticle-automation added a commit that referenced this pull request Aug 20, 2025
@mparticle-automation
chore(release): 8.38.0 [skip ci]
e629ee5 
# [8.38.0](v8.37.1...v8.38.0) (2025-08-20)

### Features

* Decouple MParticle.m for Swift Migration ([#393](#393)) ([23f5434](23f5434))
* Map Selected Identity to Emailsha256 ([#391](#391)) ([a14544b](a14544b))
@mparticle-automation
Copy link
Contributor

mparticle-automation commented Aug 20, 2025

🎉 This PR is included in version 8.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesnrokt jamesnrokt jamesnrokt approved these changes

@nickolas-dimitrakas nickolas-dimitrakas nickolas-dimitrakas approved these changes

Assignees

@BrandonStalnaker BrandonStalnaker

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrandonStalnaker @mparticle-automation @jamesnrokt @nickolas-dimitrakas