Skip to content

Conversation

@denischilik
Copy link
Contributor

@denischilik denischilik commented Aug 19, 2025

Summary

First stage of mParticle.m refactoring where some classes were moved from mParticle.m to their own files.
These classes were covered with tests. And obj-c tests were rewritten in swift.

Testing Plan

  • Was this tested locally? If not, explain why.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker
Copy link
Collaborator

Could you detail how you tested this besides unit tests?

@denischilik denischilik force-pushed the feat/SDKE-60-decouple-mparticle-m-for-swift-migration branch from ff27f56 to 0275754 Compare August 20, 2025 11:38
@denischilik
Copy link
Contributor Author

Could you detail how you tested this besides unit tests?

Could you clarify what kind of additional testing you have in mind apart from unit tests? Since this change is purely a refactor without any business logic modifications, I focused on ensuring coverage with unit tests.

@BrandonStalnaker
Copy link
Collaborator

Just some basic smoke tests. Get some events to show on the live stream in the cocoapods Example app and Higgs app. I understand that a lot of this is just cut and paste/reorganization but considering we know the unit tests are lacking we can't only rely on them and this is a fairly big change.

@denischilik
Copy link
Contributor Author

Just some basic smoke tests. Get some events to show on the live stream in the cocoapods Example app and Higgs app. I understand that a lot of this is just cut and paste/reorganization but considering we know the unit tests are lacking we can't only rely on them and this is a fairly big change.

I have checked with both the Example and Higgs apps, and confirmed that live events still show up as expected.

Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for putting up with my requests 😆

Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, went over majority of this in person. Only comment is to maybe cancel the job that has been running for over 5 hours native-unit-tests (iOS, mParticle-Apple-SDK-NoLocation). It seems to be hung on BackendController Unit Tests with the last output being:
Test Case '-[MPBackendControllerTests testAutomaticSessionEnd]' started.

@denischilik denischilik merged commit 23f5434 into development Aug 20, 2025
12 of 13 checks passed
@denischilik denischilik deleted the feat/SDKE-60-decouple-mparticle-m-for-swift-migration branch August 20, 2025 17:20
mparticle-automation added a commit that referenced this pull request Aug 20, 2025
# [8.38.0](v8.37.1...v8.38.0) (2025-08-20)

### Features

* Decouple MParticle.m for Swift Migration ([#393](#393)) ([23f5434](23f5434))
* Map Selected Identity to Emailsha256 ([#391](#391)) ([a14544b](a14544b))
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants