Skip to content

Conversation

@denischilik
Copy link
Contributor

Summary

  • MPAttributionResult wasn't synthesize setter because private header wasn't imported, but the core of the problem was that MPKitAPI class was using private property which wasn't available to them. We should consider to make this property readwrite in public interface instead creating private category or import related header to all places where we create this new private category.
  • create Tech Dept ticket https://rokt.atlassian.net/browse/SDKE-236

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets makes sure all the tests pass before merging but it looks good to me!

@denischilik denischilik merged commit a62f308 into development Sep 17, 2025
38 of 50 checks passed
@denischilik denischilik deleted the fix/SDKE-235-Crash-in-MPKitApi-to-dev branch September 17, 2025 19:24
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 8.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants