test: Add test coverage for logCommerceEvent and logEvent #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-dimitrakas
force-pushed
the
test/add-test-coverage-for-log-commerce-event-method
branch
from
9e283cc to
2d7c947
Compare
…https://github.com/mParticle/mparticle-apple-sdk into test/add-test-coverage-for-log-commerce-event-method
BrandonStalnaker
approved these changes
Sep 22, 2025
Collaborator
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Pair reviewed with Nick over GMeeting
nickolas-dimitrakas
deleted the
test/add-test-coverage-for-log-commerce-event-method
branch
jamesnrokt
added a commit
that referenced
this pull request
Oct 1, 2025
* test: Add test coverage for logCommerceEvent and logEvent (#414) * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * result of call with @BrandonStalnaker * remove unnecessary nil check from logCommerceEvent * test: add test coverage for log ltv increase methods (#417) * Organize tests into a mark * added full test coverage for LTVIncrease * fix misspell of mock parameter * add comments to make more readable * ci: Update Release YML to release from Main (#415) * test: repurpose MPSwiftTests and cover MPEvent (#420) * implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes * implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes --------- Co-authored-by: denischilik <[email protected]> * test: SDKE-255 Add test coverage for add test coverage for leave breadcrumb method (#424) * - move BreadcrumbTest to their section and increase coverage * - initialize kits container once * - executor initialized in one place * - move backend controller initialization to one place * - move MPStateMachineMock initialization to one place * - add tests for leaveBreadcrumbCallback * - add tests for leaveBreadcrumb --------- Co-authored-by: Nickolas Dimitrakas <[email protected]> Co-authored-by: Brandon Stalnaker <[email protected]> Co-authored-by: denischilik <[email protected]> Co-authored-by: denischilik <[email protected]>
nickolas-dimitrakas
added a commit
that referenced
this pull request
Oct 1, 2025
* test: Add test coverage for logCommerceEvent and logEvent (#414) * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * result of call with @BrandonStalnaker * remove unnecessary nil check from logCommerceEvent * test: add test coverage for log ltv increase methods (#417) * Organize tests into a mark * added full test coverage for LTVIncrease * fix misspell of mock parameter * add comments to make more readable * initialize trunk * adjustment to trunk config * need to remove yamllint from enabled * add swiftlint and swiftformat * add react native gemfile to ignored * format * ci: Update Release YML to release from Main (#415) * test: repurpose MPSwiftTests and cover MPEvent (#420) * implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes * implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes --------- Co-authored-by: denischilik <[email protected]> * test: SDKE-255 Add test coverage for add test coverage for leave breadcrumb method (#424) * - move BreadcrumbTest to their section and increase coverage * - initialize kits container once * - executor initialized in one place * - move backend controller initialization to one place * - move MPStateMachineMock initialization to one place * - add tests for leaveBreadcrumbCallback * - add tests for leaveBreadcrumb * remove unused linters and add comments for clarity * Revert "format" This reverts commit 3816a59. * format with new config * add objc formatter * objc formatting * Revert "objc formatting" This reverts commit 4dd23e3. * Revert "add objc formatter" This reverts commit b76b520. * added basic swift configs for trunk to use * remove duplicated funcs from merge * format build and lint file --------- Co-authored-by: Brandon Stalnaker <[email protected]> Co-authored-by: denischilik <[email protected]> Co-authored-by: denischilik <[email protected]>
mparticle-automation
added a commit
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
logCommerceEventandlogEventTesting Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)