Skip to content

Conversation

@BrandonStalnaker
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • This PR updates the repository to support newly agreed upon standards in regards to branching and release strategy.

Testing Plan

  • Was this tested locally? If not, explain why.
  • This is a github action and therefor can't be ran locally

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this Sep 22, 2025
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner September 22, 2025 16:52
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 745877b into development Sep 29, 2025
15 of 16 checks passed
@BrandonStalnaker BrandonStalnaker deleted the ci/SDKE-164-Update-Release-Script-To-Release-From-Main branch September 29, 2025 13:13
jamesnrokt added a commit that referenced this pull request Oct 1, 2025
* test: Add test coverage for logCommerceEvent and logEvent (#414)

* added test for logCommerceEvent when event is nil

* full test coverage for logCommerceEvent

* full test coverage for logEvent

* added test for logCommerceEvent when event is nil

* full test coverage for logCommerceEvent

* full test coverage for logEvent

* result of call with @BrandonStalnaker

* remove unnecessary nil check from logCommerceEvent

* test: add test coverage for log ltv increase methods (#417)

* Organize tests into a mark

* added full test coverage for LTVIncrease

* fix misspell of mock parameter

* add comments to make more readable

* ci: Update Release YML to release from Main (#415)

* test: repurpose MPSwiftTests and cover MPEvent (#420)

* implemented new logger functionality and extracted MPEvent tests

Co-Authored-By: denischilik <[email protected]>

* Remove old macros logger

* fully covered hash and isEqual methods

* added full coverage for copyWithZone

* covered setCategory method

* covered public accessors

* covered beginTiming method

* covered  breadcrumbDictionaryRepresentation

* covered endTiming

* adjust function naming

* covered screenDictionaryRepresentation

* extracted MPIdentity from MPSwiftTests to new file

* removed event builder and renamed files + classes

* implemented new logger functionality and extracted MPEvent tests

Co-Authored-By: denischilik <[email protected]>

* Remove old macros logger

* fully covered hash and isEqual methods

* added full coverage for copyWithZone

* covered setCategory method

* covered public accessors

* covered beginTiming method

* covered  breadcrumbDictionaryRepresentation

* covered endTiming

* adjust function naming

* covered screenDictionaryRepresentation

* extracted MPIdentity from MPSwiftTests to new file

* removed event builder and renamed files + classes

---------

Co-authored-by: denischilik <[email protected]>

* test: SDKE-255 Add test coverage for add test coverage for leave breadcrumb method (#424)

* - move BreadcrumbTest to their section and increase coverage

* - initialize kits container once

* - executor initialized in one place

* - move backend controller initialization to one place

* - move MPStateMachineMock initialization to one place

* - add tests for leaveBreadcrumbCallback

* - add tests for leaveBreadcrumb

---------

Co-authored-by: Nickolas Dimitrakas <[email protected]>
Co-authored-by: Brandon Stalnaker <[email protected]>
Co-authored-by: denischilik <[email protected]>
Co-authored-by: denischilik <[email protected]>
nickolas-dimitrakas added a commit that referenced this pull request Oct 1, 2025
* test: Add test coverage for logCommerceEvent and logEvent (#414)

* added test for logCommerceEvent when event is nil

* full test coverage for logCommerceEvent

* full test coverage for logEvent

* added test for logCommerceEvent when event is nil

* full test coverage for logCommerceEvent

* full test coverage for logEvent

* result of call with @BrandonStalnaker

* remove unnecessary nil check from logCommerceEvent

* test: add test coverage for log ltv increase methods (#417)

* Organize tests into a mark

* added full test coverage for LTVIncrease

* fix misspell of mock parameter

* add comments to make more readable

* initialize trunk

* adjustment to trunk config

* need to remove yamllint from enabled

* add swiftlint and swiftformat

* add react native gemfile to ignored

* format

* ci: Update Release YML to release from Main (#415)

* test: repurpose MPSwiftTests and cover MPEvent (#420)

* implemented new logger functionality and extracted MPEvent tests

Co-Authored-By: denischilik <[email protected]>

* Remove old macros logger

* fully covered hash and isEqual methods

* added full coverage for copyWithZone

* covered setCategory method

* covered public accessors

* covered beginTiming method

* covered  breadcrumbDictionaryRepresentation

* covered endTiming

* adjust function naming

* covered screenDictionaryRepresentation

* extracted MPIdentity from MPSwiftTests to new file

* removed event builder and renamed files + classes

* implemented new logger functionality and extracted MPEvent tests

Co-Authored-By: denischilik <[email protected]>

* Remove old macros logger

* fully covered hash and isEqual methods

* added full coverage for copyWithZone

* covered setCategory method

* covered public accessors

* covered beginTiming method

* covered  breadcrumbDictionaryRepresentation

* covered endTiming

* adjust function naming

* covered screenDictionaryRepresentation

* extracted MPIdentity from MPSwiftTests to new file

* removed event builder and renamed files + classes

---------

Co-authored-by: denischilik <[email protected]>

* test: SDKE-255 Add test coverage for add test coverage for leave breadcrumb method (#424)

* - move BreadcrumbTest to their section and increase coverage

* - initialize kits container once

* - executor initialized in one place

* - move backend controller initialization to one place

* - move MPStateMachineMock initialization to one place

* - add tests for leaveBreadcrumbCallback

* - add tests for leaveBreadcrumb

* remove unused linters and add comments for clarity

* Revert "format"

This reverts commit 3816a59.

* format with new config

* add objc formatter

* objc formatting

* Revert "objc formatting"

This reverts commit 4dd23e3.

* Revert "add objc formatter"

This reverts commit b76b520.

* added basic swift configs for trunk to use

* remove duplicated funcs from merge

* format build and lint file

---------

Co-authored-by: Brandon Stalnaker <[email protected]>
Co-authored-by: denischilik <[email protected]>
Co-authored-by: denischilik <[email protected]>
mparticle-automation added a commit that referenced this pull request Oct 10, 2025
# [8.40.0](v8.39.0...v8.40.0) (2025-10-10)

### Features

* implement trunk tools ([#429](#429)) ([273bd70](273bd70)), closes [#414](#414) [#417](#417) [#415](#415) [#420](#420)
samdozor pushed a commit that referenced this pull request Oct 13, 2025
* implement trunk tools ([#429](#429)) ([273bd70](273bd70)), closes [#414](#414) [#417](#417) [#415](#415) [#420](#420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants