docs: Updated readme file and add contributing and release file #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * result of call with @BrandonStalnaker * remove unnecessary nil check from logCommerceEvent
* Organize tests into a mark * added full test coverage for LTVIncrease * fix misspell of mock parameter * add comments to make more readable
Mansi-mParticle
force-pushed
the
docs/SDKE-265-readme-contributing-release-update
branch
from
ea994c7 to
5e34647
Compare
Mansi-mParticle
requested review from
BrandonStalnaker,
denischilik and
nickolas-dimitrakas
nickolas-dimitrakas
approved these changes
Sep 25, 2025
rmi22186
reviewed
Sep 25, 2025
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
Need to wait for https://github.com/mParticle/mparticle-apple-sdk/pull/415/files to be merged before this one is
I'd make sure @BrandonStalnaker , who has done the most contributions, provides commentary/approval for this before merging as well.
Member
|
For some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)