feat: implement trunk tool #421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * added test for logCommerceEvent when event is nil * full test coverage for logCommerceEvent * full test coverage for logEvent * result of call with @BrandonStalnaker * remove unnecessary nil check from logCommerceEvent
* Organize tests into a mark * added full test coverage for LTVIncrease * fix misspell of mock parameter * add comments to make more readable
nickolas-dimitrakas
requested review from
BrandonStalnaker,
Mansi-mParticle,
denischilik and
thomson-t
thomson-t
previously approved these changes
Sep 26, 2025
BrandonStalnaker
previously approved these changes
Sep 29, 2025
* implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes * implemented new logger functionality and extracted MPEvent tests Co-Authored-By: denischilik <[email protected]> * Remove old macros logger * fully covered hash and isEqual methods * added full coverage for copyWithZone * covered setCategory method * covered public accessors * covered beginTiming method * covered breadcrumbDictionaryRepresentation * covered endTiming * adjust function naming * covered screenDictionaryRepresentation * extracted MPIdentity from MPSwiftTests to new file * removed event builder and renamed files + classes --------- Co-authored-by: denischilik <[email protected]>
…dcrumb method (#424) * - move BreadcrumbTest to their section and increase coverage * - initialize kits container once * - executor initialized in one place * - move backend controller initialization to one place * - move MPStateMachineMock initialization to one place * - add tests for leaveBreadcrumbCallback * - add tests for leaveBreadcrumb
This reverts commit 3816a59.
nickolas-dimitrakas
dismissed stale reviews from BrandonStalnaker and thomson-t
via
29bba00
BrandonStalnaker
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)