Skip to content

Conversation

@nickolas-dimitrakas
Copy link
Contributor

Background

  • The existing listenerController tests were outdated and no longer relevant after recent refactors. They were providing no value.

What Has Changed

  • Removed listenerControllerCalled tests.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Coverage has decreased to 74%
image

Reference Issue (For employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the test/remove-old-listenerController-tests branch from d89631f to 19a556d Compare November 4, 2025 15:24
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please split this in few PR:

  • regrouping
  • test extractions
  • renaming

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the test/remove-old-listenerController-tests branch from 19a556d to 202d0c8 Compare November 4, 2025 16:42
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas merged commit cca27a1 into main Nov 4, 2025
6 of 10 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/remove-old-listenerController-tests branch November 4, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants