Skip to content

test: add coverage for endTimedEvent and eventWithName #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickolas-dimitrakas merged 4 commits into from
Nov 7, 2025
Merged

test: add coverage for endTimedEvent and eventWithName #446

nickolas-dimitrakas merged 4 commits into from
Nov 7, 2025

Conversation

@nickolas-dimitrakas
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Nov 4, 2025 •
edited
Loading

Background

  • Added comprehensive unit tests for timed event handling and event retrieval logic to improve coverage and reliability.

What Has Changed

  • Added new tests covering endTimedEvent and eventWithName

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Coverage increased to 75%
image

Reference Issue (For employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner November 4, 2025 20:27
@nickolas-dimitrakas nickolas-dimitrakas changed the title test: add coverage for end timed event and event with name test: add coverage for endTimedEvent and eventWithName Nov 5, 2025
denischilik
denischilik requested changes Nov 5, 2025
View reviewed changes
denischilik
denischilik approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BrandonStalnaker
BrandonStalnaker approved these changes Nov 7, 2025
View reviewed changes
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas merged commit e06e454 into main Nov 7, 2025
11 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/add-coverage-for-endTimedEvent-and-eventWithName branch November 7, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@denischilik denischilik denischilik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickolas-dimitrakas @BrandonStalnaker @denischilik