Skip to content

test: add coverage for logEvent:eventType:eventInfo #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickolas-dimitrakas merged 3 commits into from
Nov 7, 2025
Merged

test: add coverage for logEvent:eventType:eventInfo #447

nickolas-dimitrakas merged 3 commits into from
Nov 7, 2025

Conversation

@nickolas-dimitrakas
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Nov 4, 2025 •
edited
Loading

Background

  • Added unit tests to ensure full coverage for the logEvent:eventType:eventInfo: flow, including downstream calls to logEvent and logCustomEvent

What Has Changed

  • Added two new Swift test cases covering both branches of the event logging flow.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Coverage increased to 76%
image

Reference Issue (For employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner November 4, 2025 21:55
denischilik
denischilik approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the test/add-coverage-for-logEvent-eventType-eventInfo branch from 6830131 to c685fd2 Compare November 7, 2025 17:26
@nickolas-dimitrakas nickolas-dimitrakas merged commit fa1766c into main Nov 7, 2025
6 of 10 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/add-coverage-for-logEvent-eventType-eventInfo branch November 7, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@denischilik denischilik denischilik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickolas-dimitrakas @BrandonStalnaker @denischilik