Skip to content

Conversation

@nickolas-dimitrakas
Copy link
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Nov 5, 2025

Background

  • Added missing test coverage for logError: and logError:eventInfo: methods to ensure proper backend invocation, listener calls, and validation handling.

What Has Changed

  • Added new test cases in MParticleErrorTests for logError variants.
  • Introduced helper assertion methods to simplify mock verifications

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • Coverage increased to 77%
image

Reference Issue (For employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas force-pushed the test/add-coverage-for-logError-eventInfo branch from 4603131 to c383e23 Compare November 7, 2025 17:29
@nickolas-dimitrakas nickolas-dimitrakas merged commit 470585f into main Nov 7, 2025
10 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/add-coverage-for-logError-eventInfo branch November 7, 2025 17:33
@mparticle-automation
Copy link
Contributor

🎉 This PR is included in version 9.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants