Skip to content

Comments

feat: Update Rokt public methods to match Rokt 5.0#521

Merged
jamesnrokt merged 12 commits intoworkstation/9.0-Releasefrom
feat/adjust-select-placements
Feb 9, 2026
Merged

feat: Update Rokt public methods to match Rokt 5.0#521
jamesnrokt merged 12 commits intoworkstation/9.0-Releasefrom
feat/adjust-select-placements

Conversation

@jamesnrokt
Copy link
Collaborator

Background

  • Leaving in draft state as this will be simpler to test once the Package.swift changes are in place to allow local SPM testing
  • This PR updates the mParticle Rokt public methods to match Rokt 5.0

What Has Changed

  • Updated methods on the Rokt interface
  • Introduced global events

Screenshots/Video

  • N/A

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally. - Pending the above mentioned changes

Additional Notes

  • N/A

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • Closes SDKE-769

@github-actions
Copy link

github-actions bot commented Jan 23, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.60 MB 1.60 MB +N/A
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 5.38 MB 5.38 MB +4 KB

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5504}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1724,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1640,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5508}

@jamesnrokt jamesnrokt marked this pull request as ready for review February 9, 2026 14:59
@jamesnrokt jamesnrokt requested a review from a team as a code owner February 9, 2026 14:59
Copy link
Collaborator

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found one small thing and it's too minor to warrant delay on approval

@jamesnrokt jamesnrokt merged commit d6a6777 into workstation/9.0-Release Feb 9, 2026
14 checks passed
@jamesnrokt jamesnrokt deleted the feat/adjust-select-placements branch February 9, 2026 21:57
denischilik added a commit that referenced this pull request Feb 10, 2026
…m-main

* workstation/9.0-Release: (31 commits)
  feat: Update Rokt public methods to match Rokt 5.0 (#521)
  feat: Expose MPDateFormatter to kits (#564)
  feat: Remove NoLocation suffix (#563)
  feat: Migrate MPResponseConfigTests (#552)
  chore: Add additional unit tests for v9 (#557)
  feat: Source Based Distribution (#556)
  feat: Migrate MPUserDefaultTests (#550)
  feat: Migrate MPUserDefaults (#545)
  ci: add swift scheme (#544)
  feat: Migrate mp upload settings convert to objc updated  (#543)
  refactor: Migrate MPRoktEvent (#538)
  refactor: migrate SceneDelegateHandler to objc (#539)
  refactor: migrate mp convert js to objc (#537)
  feat: Migrate MPDevice to swift target (#535)
  refactor: Convert MPPersistenceController to Obj C (#529)
  feat: Move swift files to separate swift target part 3 (#528)
  revert: expandedInstructions return type (#532)
  refactor: migrate MPSideloadedKit to objc (#530)
  feat: direct routing by default (#508)
  feat: Move swift files to separate swift target part 2 (#527)
  ...

# Conflicts:
#	.github/workflows/sdk-release-manual.yml
#	.github/workflows/size-report.yml
#	CHANGELOG.md
#	Framework/Info.plist
#	IntegrationTests/Sources/main.swift
#	IntegrationTests/wiremock-recordings/mappings/mapping-ccpa-consent.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-commerce-event-purchase.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-gdpr-consent.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute-ss.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-session-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute-set.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-increment-user-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-error.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-event-with-flags.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-exception.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-log-screen.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-rokt-identify.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-rokt-select-placement.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-att-status.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-session-attribute.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-set-user-attributes.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-timed-event.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v1-identify.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v2-events-log-event.json
#	IntegrationTests/wiremock-recordings/mappings/mapping-v4-config-get-config.json
#	Package.swift
#	Tests/SizeReport/LocalSDK/Package.swift
#	Tests/SizeReport/SizeTestAppWithSDK/SizeTestAppWithSDK/ContentView.swift
#	UnitTests/ObjCTests/MPRoktTests.m
#	UnitTests/SwiftTests/MParticle/MParticleOpenURLTests.swift
#	UnitTests/SwiftTests/MParticle/MParticleUserActivityTests.swift
#	mParticle-Apple-SDK-Swift/Sources/Utils/MPUserDefaults.swift
#	mParticle-Apple-SDK.podspec
#	mParticle-Apple-SDK/MPBackendController.m
#	mParticle-Apple-SDK/MPConstants.swift
#	mParticle-Apple-SDK/MPIConstants.m
#	mParticle-Apple-SDK/MPRokt.m
#	mParticle-Apple-SDK/Network/MPNetworkCommunication.m
#	mParticle-Apple-SDK/SceneDelegateHandler.swift
#	mParticle-Apple-SDK/Utils/MPResponseConfig.swift
#	mParticle-Apple-SDK/mParticle.m
#	mParticle_Apple_SDK.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants