feat: RoktContracts POC Core Changes by BrandonStalnaker · Pull Request #675 · mParticle/mparticle-apple-sdk

BrandonStalnaker · 2026-03-20T15:28:03Z

DRAFT

Background

Update to use RoktContracts for mParticle and the mParticle Rokt Integration.

What Has Changed

The mParticle versions of RoktContracts classes have been removed in internal and example code
The ObjC and Swift Example have been updated to use the local version of Core and the Rokt Integration

Checklist

I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
I have added tests that prove my fix is effective or that my feature works.
I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

Closes https://go/j/[ticket-number]

SwiftExample/mParticleSwiftExample/ContentView.swift

Package.swift

Example/mParticleExample/ViewController.m

…a Swift import

Kits/rokt/rokt/Package.swift

github-actions · 2026-03-31T15:50:16Z

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric	Target Branch	This PR	Change
App Bundle Impact	1.66 MB	1.73 MB	+72 KB
Executable Impact	896 bytes	896 bytes	+N/A
XCFramework Size	5.47 MB	6.30 MB	+852 KB

⚠️ This change increases SDK size impact.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1860,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1776,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6456}

BrandonStalnaker · 2026-03-31T17:10:19Z

build rokt wil sadly fail for this PR because the tests are using the workstation branch of mParticle Core. But, once the changes here are merged, it will no longer fail.

SwiftExample/mParticleSwiftExample/ContentView.swift

cursor · 2026-03-31T18:25:46Z

PR Summary

High Risk
High risk because it changes public Rokt-facing APIs/types (MPRoktEvent, config, embedded views, placement options) and updates dependency wiring for CocoaPods/SPM/Xcode projects, which can break downstream integrations and builds.

Overview
Migrates the mParticle Rokt surface area to RoktContracts. Core and kit APIs now accept/pass through RoktContracts types (RoktEvent, RoktConfig, RoktEmbeddedView, RoktPlacementOptions) and the internal MPRoktEvent implementation is removed (events are no longer mapped; they are forwarded as-is).

Updates build/distribution plumbing to include RoktContracts. Adds RoktContracts as a dependency in the root Package.swift, core and kit podspecs, and the mParticle Xcode project; introduces a new SPM wrapper target (mParticle_Apple_SDK) that re-exports the ObjC module plus RoktContracts.

Refreshes examples/tests and local dev setup. Example apps and Rokt kit tests are updated to the new event/config APIs, Swift gets an Objective-C selector-based interop shim (MPRokt+SwiftInterop) for event subscription/select placement overloads, and the Example Podfile/SwiftExample project are adjusted to use local packages/pods; CI analyzer grep is tightened to avoid false positives.

^{Written by Cursor Bugbot for commit 433d788. This will update automatically on new commits. Configure here.}

Kits/rokt/rokt/Sources/mParticle-Rokt-Swift/MPRokt+SwiftInterop.swift

Kits/rokt/rokt/Tests/mParticle-RoktObjCTests/mParticle_RoktTests.m

Kits/rokt/rokt/Package.swift

Package.swift

cursor

Cursor Bugbot has reviewed your changes and found 4 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

cursor · 2026-03-31T20:16:56Z

Kits/rokt/rokt/mParticle-Rokt.podspec

+    # Align with monorepo mParticle-Apple-SDK.podspec (8.x). When using `pod :path`, CocoaPods
+    # resolves the local SDK; keep a loose constraint so `pod lib lint` and trunk releases stay valid.
+    s.ios.dependency 'mParticle-Apple-SDK', '>= 8.0'
+    s.ios.dependency 'RoktContracts', '~> 0.1'


Pod dependency range is too broad

Medium Severity

The mParticle-Rokt pod now allows any mParticle-Apple-SDK version >= 8.0, which can resolve to older core releases that do not include the new RoktContracts-based API surface this kit now uses. This can produce dependency resolution that installs but breaks integration compatibility at build or runtime.

cursor · 2026-03-31T20:16:56Z

.github/workflows/build-and-lint.yml

+          # Fail if any *diagnostic* warnings remain after allowlist filters.
+          # Use ': warning:' (clang/Xcode style) — not bare 'warning', which false-positives on
+          # swiftc flags like -suppress-warnings in Swift package builds (e.g. RoktContracts).
+          bash -c '! (set -o pipefail && xcodebuild -project "mParticle-Apple-SDK.xcodeproj" -scheme "mParticle-Apple-SDK" -sdk iphonesimulator -configuration Debug -destination "platform=iOS Simulator,name=iPhone 16 Pro,OS=latest" clean analyze | grep -v "warning: The iOS Simulator deployment target" | grep -v "warning: Metadata extraction skipped" | grep -F -v "Repeated use of MParticle sharedInstance in one method; assign to a local variable once." | grep -F -v "warning: Run script build phase '"'"'Run Script'"'"' will be run during every build" | grep -B3 ": warning:")'


Static analyzer warning gate now misses warnings

Low Severity

The warning detector now searches only for : warning:. Warnings emitted as warning: without a leading file-location prefix are no longer matched, so the analyzer step can succeed while genuine warnings remain in xcodebuild output.

cursor · 2026-03-31T20:16:56Z

Example/Podfile

+  pod 'RoktUXHelper', :git => 'https://github.com/ROKT/rokt-ux-helper-ios.git', :tag => '0.8.3'
+
+  # Rokt iOS SDK 5.x (aligned with Kits/rokt/rokt/Package.swift). Use Git branch; not on CocoaPods trunk.
+  pod 'Rokt-Widget', :git => 'https://github.com/ROKT/rokt-sdk-ios.git', :branch => 'workstation/5.0.0'


Example depends on temporary Git branch

Low Severity

The example now pins Rokt-Widget to a workstation branch and RoktUXHelper to a Git tag override. This introduces non-release dependency sources that can disappear or drift, making pod install for Example/Podfile fragile and intermittently failing for contributors and CI.

Additional Locations (1)

Example/Podfile#L14-L15

cursor · 2026-03-31T20:16:56Z

Kits/rokt/rokt/Sources/mParticle-Rokt/MPKitRokt.m

-        if (mpEvent) {
-            onEvent(mpEvent);
-        }
+        onEvent(event);


Nil event callback can crash kit

Medium Severity

events:onEvent: now unconditionally invokes onEvent(event) without checking whether onEvent is nil. The protocol declares onEvent as nullable, so a nil callback can be forwarded from MPRokt and cause a runtime crash when an event arrives.

BrandonStalnaker requested a review from a team as a code owner March 20, 2026 15:28

BrandonStalnaker marked this pull request as draft March 20, 2026 15:28

cursor bot reviewed Mar 20, 2026

View reviewed changes

SwiftExample/mParticleSwiftExample/ContentView.swift Show resolved Hide resolved

Package.swift Outdated Show resolved Hide resolved

jamesnrokt reviewed Mar 20, 2026

View reviewed changes

Example/mParticleExample/ViewController.m Show resolved Hide resolved

BrandonStalnaker force-pushed the feat/RoktContracts-POC branch from 7b0edb6 to d5d1261 Compare March 23, 2026 14:00

BrandonStalnaker added 4 commits March 30, 2026 12:34

feat: RoktContracts POC Core Changes

52a9b39

automatically import RoktContracts library

d382e22

kit changes and SwiftExample attempt

1bb5b7c

Add Swift Extension

5eba563

BrandonStalnaker force-pushed the feat/RoktContracts-POC branch from ab290f7 to e4ba3ec Compare March 30, 2026 18:54

BrandonStalnaker added 2 commits March 31, 2026 10:30

Update import to include mParticle core and RoktContracts as part of …

2481336

…a Swift import

Swift Example working

7327beb

BrandonStalnaker force-pushed the feat/RoktContracts-POC branch from e4ba3ec to 7327beb Compare March 31, 2026 14:37

BrandonStalnaker commented Mar 31, 2026

View reviewed changes

Kits/rokt/rokt/Package.swift Outdated Show resolved Hide resolved

Local cocoapods Example app finalized

e039bd1

BrandonStalnaker force-pushed the feat/RoktContracts-POC branch from 76a8444 to e039bd1 Compare March 31, 2026 15:44

adjust for release

b568299

BrandonStalnaker self-assigned this Mar 31, 2026

Merge branch 'workstation/9.0-Release' into feat/RoktContracts-POC

e8ddc1b

BrandonStalnaker marked this pull request as ready for review March 31, 2026 17:10

BrandonStalnaker requested review from jamesnrokt, nickolas-dimitrakas and thomson-t March 31, 2026 17:10

thomson-t reviewed Mar 31, 2026

View reviewed changes

SwiftExample/mParticleSwiftExample/ContentView.swift Outdated Show resolved Hide resolved

address CR

50e02b7

cursor bot reviewed Mar 31, 2026

View reviewed changes

Kits/rokt/rokt/Sources/mParticle-Rokt-Swift/MPRokt+SwiftInterop.swift Show resolved Hide resolved

Kits/rokt/rokt/Tests/mParticle-RoktObjCTests/mParticle_RoktTests.m Show resolved Hide resolved

thomson-t reviewed Mar 31, 2026

View reviewed changes

Kits/rokt/rokt/Package.swift Outdated Show resolved Hide resolved

Package.swift Outdated Show resolved Hide resolved

BrandonStalnaker and others added 2 commits March 31, 2026 16:10

Address CR 2

e1ac7d8

Merge branch 'workstation/9.0-Release' into feat/RoktContracts-POC

433d788

BrandonStalnaker requested a review from thomson-t March 31, 2026 20:12

cursor bot reviewed Mar 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: RoktContracts POC Core Changes#675

feat: RoktContracts POC Core Changes#675
BrandonStalnaker wants to merge 12 commits intoworkstation/9.0-Releasefrom
feat/RoktContracts-POC

BrandonStalnaker commented Mar 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

BrandonStalnaker commented Mar 31, 2026

Uh oh!

Uh oh!

cursor bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

BrandonStalnaker commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Background

What Has Changed

Checklist

Reference Issue (For employees only. Ignore if you are an outside contributor)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 SDK Size Impact Report

Uh oh!

BrandonStalnaker commented Mar 31, 2026

Uh oh!

Uh oh!

cursor bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Pod dependency range is too broad

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Static analyzer warning gate now misses warnings

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Example depends on temporary Git branch

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Nil event callback can crash kit

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

BrandonStalnaker commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 31, 2026 •

edited

Loading

cursor bot commented Mar 31, 2026 •

edited

Loading