WIP: feat: adopt Rokt SDK v5 contract types in public API#678
Draft
thomson-t wants to merge 2 commits intoworkstation/9.0-Releasefrom
Draft
WIP: feat: adopt Rokt SDK v5 contract types in public API#678thomson-t wants to merge 2 commits intoworkstation/9.0-Releasefrom
thomson-t wants to merge 2 commits intoworkstation/9.0-Releasefrom
Conversation
Replace mParticle-prefixed wrapper types (MPRoktEmbeddedView, MPRoktConfig, MPRoktEvent, MPRoktPlacementOptions, MPColorMode) with Rokt SDK native types (RoktEmbeddedView, RoktConfig, RoktEvent, RoktPlacementOptions) across the public API surface. - Remove MPRoktEvent.h/.m and MPRoktConfig/MPRoktEmbeddedView definitions — consumers now use types from the Rokt SDK directly - Update MPKitProtocol.h to forward-declare Rokt SDK types - Update MPRokt.h/.m to use Rokt SDK types in selectPlacements, events, and globalEvents signatures - Update Rokt kit (MPKitRokt) to bridge with native types - Update example apps, unit tests, and Xcode/SPM project files - Add Rokt SDK dependency to the kit podspec Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| let roktConfig = RoktConfig.Builder().colorMode(.dark).build() | ||
|
|
||
| MParticle.sharedInstance().rokt.selectPlacements( | ||
| "RoktLayout", |
Collaborator
There was a problem hiding this comment.
This code is whats failing to compile for me. You might check and see if AI fixed this by making it call the simpler method without the RoktContracts classes. It did that to me before I caught it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MPRoktEmbeddedView,MPRoktConfig,MPRoktEvent,MPRoktPlacementOptions,MPColorMode) with Rokt SDK native types (RoktEmbeddedView,RoktConfig,RoktEvent,RoktPlacementOptions)MPRoktEvent.h/.m— consumers now use types from the Rokt SDK directlyMPKitProtocol.h,MPRokt.h/.m, Rokt kit, example apps, and unit testsTest plan
pod lib lintpasses🤖 Generated with Claude Code