Skip to content

chore: set module_name on versioned kit podspecs#682

Merged
nickolas-dimitrakas merged 4 commits intoworkstation/9.0-Releasefrom
chore/set-module-name-on-versioned-kit-podspecs
Mar 24, 2026
Merged

chore: set module_name on versioned kit podspecs#682
nickolas-dimitrakas merged 4 commits intoworkstation/9.0-Releasefrom
chore/set-module-name-on-versioned-kit-podspecs

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Mar 24, 2026

Background

  • CocoaPods derives the module name from the pod name by replacing - with _, so versioned pods like mParticle-Braze-12 produced import mParticle_Braze_12 instead of import mParticle_Braze.
  • The version suffix belongs in the Podfile install declaration only — source imports should be stable across major version bumps.

What Has Changed

  • 25 versioned kit podspecs — Added s.module_name to each, stripping the numeric suffix (e.g. mParticle_Braze for mParticle-Braze-12/13/14).
  • mParticle-OneTrust and mParticle-Rokt are unchanged (no version suffix in their names).

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

NO JIRA

Adds s.module_name to each versioned kit podspec so that consumers
import the kit without the version suffix (e.g. import mParticle_Braze
instead of import mParticle_Braze_12).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner March 24, 2026 14:37
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 24, 2026

PR Summary

Low Risk
Low risk: podspec metadata-only changes, but renaming s.name/podspec paths can affect CocoaPods resolution and consumers’ Podfile declarations.

Overview
Stabilizes Swift/ObjC import module names for versioned kits. Adds explicit s.module_name to many version-suffixed kit podspecs so consumers import stable modules like mParticle_Braze instead of versioned variants.

Renames Firebase and Firebase GA4 pod names/podspecs. Updates s.name for the Firebase/FirebaseGA4 kits (removing the long mParticle-Google-Analytics-Firebase... prefix) and adjusts Kits/matrix.json to point to the renamed podspec files.

Written by Cursor Bugbot for commit 9052d3c. This will update automatically on new commits. Configure here.

@nickolas-dimitrakas nickolas-dimitrakas self-assigned this Mar 24, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.65 MB 1.65 MB +N/A
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 5.45 MB 5.45 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1772,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1688,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5584}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1772,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1688,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5584}

nickolas-dimitrakas and others added 2 commits March 24, 2026 10:45
Rename mParticle-Google-Analytics-Firebase-{11,12} → mParticle-Firebase-{11,12}
and mParticle-Google-Analytics-Firebase-GA4-{11,12} → mParticle-FirebaseGA4-{11,12}
to match SPM target names, and set module_name accordingly so CocoaPods and
SPM consumers use the same import (import mParticle_Firebase / import mParticle_FirebaseGA4).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas merged commit d77e28f into workstation/9.0-Release Mar 24, 2026
137 of 138 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the chore/set-module-name-on-versioned-kit-podspecs branch March 24, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants