Skip to content

feat: Allow Client to Manually Call AppsFlyer Start#691

Merged
nickolas-dimitrakas merged 6 commits intoworkstation/9.0-Releasefrom
feat/appsflyer-manual-start
Mar 31, 2026
Merged

feat: Allow Client to Manually Call AppsFlyer Start#691
nickolas-dimitrakas merged 6 commits intoworkstation/9.0-Releasefrom
feat/appsflyer-manual-start

Conversation

@nickolas-dimitrakas
Copy link
Copy Markdown
Contributor

@nickolas-dimitrakas nickolas-dimitrakas commented Mar 31, 2026

Background

What Has Changed

  • Only call AppsFlyer start when the manualStart configuration flag is false (or absent)
  • Remove setSharingFilterForPartners logic and the sharingFilterForPartnersFromConfiguration: method
  • Add startCallCount tracking to AppsFlyerLibMock and new unit tests for didBecomeActive / manualStart behavior
  • Added retry logic in pod lib lint jobs to combat rate limit

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

  • NO JIRA

Duplicate changes from mparticle-apple-integration-appsflyer PR #51
into the monorepo AppsFlyer kit (appsflyer-6).

- Only call AppsFlyer start when manualStart flag is false
- Remove setSharingFilterForPartners logic
- Add tests for manualStart behavior

Made-with: Cursor
@nickolas-dimitrakas nickolas-dimitrakas requested a review from a team as a code owner March 31, 2026 14:41
@cursor
Copy link
Copy Markdown

cursor bot commented Mar 31, 2026

PR Summary

Medium Risk
Changes when the AppsFlyer SDK is started and removes partner sharing-filter configuration, which may impact attribution/startup behavior for existing integrations. CI-only retry logic is low risk but could mask intermittent lint issues.

Overview
Adds a manualStart configuration option for the AppsFlyer kit so didBecomeActive only calls AppsFlyer start() when the flag is false or absent, enabling clients to start AppsFlyer themselves.

Removes the sharingFilterForPartners configuration parsing and the corresponding setSharingFilterForPartners call, and updates tests/mocks to assert the new manualStart start-call behavior.

Improves the pod lib lint GitHub Action by retrying the lint step up to 3 times with a delay to reduce flakiness.

Written by Cursor Bugbot for commit 2140b22. This will update automatically on new commits. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.66 MB 1.66 MB +N/A
Executable Impact 896 bytes 896 bytes +N/A
XCFramework Size 5.47 MB 5.47 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (workstation/9.0-Release):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604}

nickolas-dimitrakas and others added 5 commits March 31, 2026 11:09
… pod lint jobs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…DN rate limiting

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…apods CDN dir

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e limiting

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nickolas-dimitrakas nickolas-dimitrakas merged commit 7c80d1a into workstation/9.0-Release Mar 31, 2026
202 of 205 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the feat/appsflyer-manual-start branch March 31, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants