feat: Support UserIdentificationType in AppsFlyer Kit#692
Conversation
Duplicate changes from mparticle-apple-integration-appsflyer PR #54 into the monorepo AppsFlyer kit (appsflyer-6). - Add userIdentificationType config (MPID, CustomerId, legacy) - Sync AppsFlyer customer user ID via identity callbacks - Route commerce/event af_customer_user_id through customerIDForAppsFlyer: - MPID mode skips setCustomerUserID on setUserIdentity:customerId - Add mock tracking and tests for all identity modes Made-with: Cursor
PR SummaryMedium Risk Overview The kit now syncs Written by Cursor Bugbot for commit f5c380c. This will update automatically on new commits. Configure here. |
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1788,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1704,"sdk_executable_impact_bytes":896,"xcframework_size_kb":5604} |
denischilik
left a comment
There was a problem hiding this comment.
Few changes, the rest looks good
Kits/appsflyer/appsflyer-6/Sources/mParticle-AppsFlyer/MPKitAppsFlyer.m
Outdated
Show resolved
Hide resolved
…serIdentity Address PR review feedback: - Extract repeated MPKitExecStatus success creation into successStatus helper - Simplify setUserIdentity by removing duplicated success status branches Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
e66566f
into
workstation/9.0-Release

Background
What Has Changed
userIdentificationTypeconfig so AppsFlyer's customer user ID can follow MPID, CustomerId, or legacy behavioronIdentifyComplete,onLoginComplete,onLogoutComplete,onModifyComplete)setUserIdentityin MPID mode ignores customer-ID identity for AppsFlyer's customer user ID but still returns successaf_customer_user_idviacustomerIDForAppsFlyer:customerUserIDproperty for test assertionssetUserIdentityfor legacy, CustomerId, and MPID modes plus email and unsupported identity typesChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)