fix: Refactor RoktManager with deferred call handling and message queue processing

[alexs-mparticle]

Instructions

1. PR target branch should be against development
2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

• Refactors the queueMessage logic of the Rokt Manager to defer promises for Rokt functions so that consumers can properly await the results.

Testing Plan

• Was this tested locally? If not, explain why.
• Using a sample web app, make a call to selectPlacements that triggers before the mParticle web sdk finishes loading the Rokt Web Kit. The call should return placements correctly after queuing.

As an example:

mParticle.ready( async function () {
  try {
    const selection = await window.mParticle.Rokt.selectPlacements({
        identifier: `mparticle-layout-test`,
        attributes: {
            email: 'test@email.com',
            firstname: 'Kain',
            lastname: 'Marko',
        }
    });
    selection.on('OFFER_ENGAGEMENT').subscribe(function (data) {
        console.log('offer engagement fired', data);
    });
  } catch (error) {
    console.error('Error selectPlacements:', error);
  }
});

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

• Closes https://go.mparticle.com/work/SQDSDKS-7404

[rmi22186]

How about removing messageQueue completely and have all the logic go based off if pendingPromises has anything in it? Then the type for the key could include resolve, reject, payload, method. This way we don't need 2 different queues.

[rmi22186]

nit: Add this identical test above to line 1103 but it'd be

expect(roktManager['pendingPromises'].has(messageId)).toBe(true);

[rmi22186]

Can this be combined with the first test? Seems like it's mostly doing the same thing...but adding a few extra checks.

[alexs-mparticle]

They're different tests. This one is handling a generic promise that resolves, but the test above handles a promise that has been rejected.

[rmi22186]

i was referring to not the test above, but the first test should resolve pending promise with success result

[rmi22186]

const queuedMessage = roktManager['messageQueue'].values()[0].value;

[rmi22186]

here and elsewhere where you have .next

[rmi22186]

Suggested change

	it.only('should create a deferred promise with unique messageId', () => {
	it('should create a deferred promise with unique messageId', () => {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rmi22186]

tested locally and looks good. great work!

this will require a docs update. we need to let customers know to wrap selectplacement in mParticle.ready here https://docs.rokt.com/developers/integration-guides/getting-started/ecommerce/ecommerce-sdk-integration#5-show-a-placement

[mparticle-automation]

🎉 This PR is included in version 2.43.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀