Skip to content

ci: Add node version 24 and 25 to workflow #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaissica12 merged 3 commits into from
Oct 29, 2025
Merged

ci: Add node version 24 and 25 to workflow #1109

jaissica12 merged 3 commits into from
Oct 29, 2025

Conversation

@jaissica12
Copy link
Contributor

@jaissica12 jaissica12 commented Oct 24, 2025 •
edited
Loading

Background

  • Add latest Node version 24 and 25 to jest test matrix.

What Has Changed

  • Updated jest test matrix with Node version 24 and 25 in pull-request.yml

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 requested a review from rmi22186 October 28, 2025 15:31
@jaissica12 jaissica12 marked this pull request as ready for review October 28, 2025 15:31
jaissica12
jaissica12 commented Oct 28, 2025
View reviewed changes
.github/workflows/staging-step-1.yml Outdated
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: latest
Copy link
Contributor Author

@jaissica12 jaissica12 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmi22186 Since this version is related to perform release, wanted to know opinion on if we want to use latest node version or LTS(22.x) (recommended approach) or want to hard code any specific version?

Copy link
Member

@rmi22186 rmi22186 Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard coding is always better since things can be break with latest

Copy link
Contributor Author

@jaissica12 jaissica12 Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying! Opted to hardcode Node 24.x since it’s the latest even-numbered release which is Active LTS, ensuring long-term stability and security updates.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jaissica12 jaissica12 requested a review from rmi22186 October 28, 2025 17:49
@jaissica12 jaissica12 merged commit 801717d into development Oct 29, 2025
27 of 31 checks passed
@mparticle-automation
Copy link
Collaborator

mparticle-automation commented Nov 10, 2025

🎉 This PR is included in version 2.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaissica12 @mparticle-automation @rmi22186