Skip to content

Conversation

@jaissica12
Copy link
Contributor

Background

  • We have duplicate methods - startNewSession and endSession in mparticle-instance-manager

What Has Changed

  • Removed duplicate startNewSession and endSession methods

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@jaissica12 jaissica12 requested a review from rmi22186 October 29, 2025 19:39
@sonarqubecloud
Copy link

@rmi22186
Copy link
Member

@jaissica12 i would rename this from chore to refactor. chore is more for updating versions, building files, things like that

@jaissica12 jaissica12 changed the title chore: remove duplicate session methods from instance-manager refactor: remove duplicate session methods from instance-manager Oct 31, 2025
@jaissica12 jaissica12 merged commit b1bd495 into development Nov 3, 2025
169 of 185 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants