Skip to content

Conversation

@rmi22186
Copy link
Member

@rmi22186 rmi22186 commented Nov 17, 2025

Background

A DAS is required for the identity framework to succeed for anonymous users. Previously no DAS was created due to initializeStorage returning early under a newly introduced code path for a noFunctional setting for launcherOptions . With this PR, a DAS is created for the purposes of the identity call succeeding but is never saved to persistence.

What Has Changed

  • Call storeDataInMemory with no arguments which reuses existing code to create a new DAS.

Screenshots/Video

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@rmi22186 rmi22186 requested a review from jaissica12 November 17, 2025 19:59
@rmi22186 rmi22186 changed the base branch from master to development November 17, 2025 21:06
@rmi22186 rmi22186 closed this Nov 17, 2025
@rmi22186 rmi22186 reopened this Nov 17, 2025
Copy link
Contributor

@jaissica12 jaissica12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarqubecloud
Copy link

@samdozor samdozor self-requested a review November 19, 2025 18:40
Copy link
Contributor

@samdozor samdozor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we chatted - this mapping shouldn't exist. we can bring it back if we want but the guidance for clients should be that if they do, they need to be setting a persistent ID, otherwise we will blow up identity

@rmi22186 rmi22186 closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants