Skip to content

Conversation

@jaissica12
Copy link
Contributor

@jaissica12 jaissica12 commented Nov 19, 2025

Background

  • This PR reverts the privacy control functionality that was previously implemented to prevent SDK state persistence, identity caching, offline event storage, and time-on-site tracking based on noFunctional and noTargeting privacy flags from launcherOptions.

What Has Changed

1. Identity Cache - Previously controlled by noFunctional

  • Identity cache now always persists to localStorage via LocalStorageVault
  • Removed DisabledVault class

2. Offline Event Storage - Previously controlled by noFunctional

  • Events now always persist to sessionStorage when available
  • Failed batches now always persist to localStorage when available
  • Removed privacy checks from BatchUploader

3. Time on Site Tracking - Previously controlled by noTargeting

  • Time tracking now always initializes when workspaceToken is present
  • Removed privacy checks from ForegroundTimer initialization

4. SDK State Persistence - Previously controlled by noFunctional

  • SDK state now always persists to cookies/localStorage
  • Removed entire privacy control system:
    • noFunctional and noTargeting properties and methods from Store
    • PrivacyControl, StorageTypes, and StoragePrivacyMap types
    • getPrivacyFlag() method
    • Privacy flag checks from persistence layer

Screenshots/Video

  • {Include any screenshots or video demonstrating the new feature or fix, if applicable}

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Additional Notes

  • {Any additional information or context relevant to this PR}

Reference Issue (For employees only. Ignore if you are an outside contributor)

@sonarqubecloud
Copy link

@jaissica12 jaissica12 changed the title refactor: remove identity cache privacy control dependencies refactor: Revert noFunctional/noTargeting privacy controls Nov 20, 2025
@jaissica12 jaissica12 requested a review from rmi22186 November 20, 2025 01:23
@jaissica12 jaissica12 marked this pull request as ready for review November 20, 2025 01:23
@rmi22186 rmi22186 changed the title refactor: Revert noFunctional/noTargeting privacy controls refactor: Revert noFunctional/noTargeting mappings Nov 20, 2025
@rmi22186
Copy link
Member

Will need @samdozor 's approval before we merge, but LGTM

@rmi22186 rmi22186 requested a review from samdozor November 20, 2025 02:35
@jaissica12 jaissica12 merged commit ce57997 into development Nov 20, 2025
28 of 32 checks passed
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 2.50.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants