refactor: Migrate mParticle Instance to TypeScript #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alexs-mparticle merged 2 commits into development from refactor/SQDSDKS-4804-mp-instance-ts

Feb 5, 2025

Collaborator

alexs-mparticle commented Jan 22, 2025 •

edited

Loading

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Migrates mP Instance to TypeScript
Splits out mP Instance and Instance Manager Definitions

Testing Plan

Was this tested locally? If not, explain why.
{explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-4804
Relies on refactor: Migrate mParticle Instance Imports #969 to be merged in first

alexs-mparticle requested review from einsteinx2 and rmi22186

January 22, 2025 21:56

alexs-mparticle commented

View reviewed changes

src/mp-instance.ts Outdated Show resolved Hide resolved

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch 3 times, most recently from e24a748 to 744665d Compare

January 24, 2025 16:35

alexs-mparticle force-pushed the refactor/ts-migration-blackout-2024 branch from 78a0cb2 to c9a2723 Compare

January 27, 2025 15:23

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from 744665d to 89f458e Compare

January 28, 2025 15:58

alexs-mparticle commented

View reviewed changes

src/mp-instance.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/mp-instance.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/sdkRuntimeModels.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/sdkRuntimeModels.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/sdkRuntimeModels.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/serverModel.ts Outdated Show resolved Hide resolved

alexs-mparticle commented

View reviewed changes

src/serverModel.ts Outdated Show resolved Hide resolved

rmi22186 requested changes

View reviewed changes

Member

rmi22186 left a comment

thanks for your patience!

test/src/tests-kit-blocking.ts Outdated Show resolved Hide resolved

src/batchUploader.ts Outdated Show resolved Hide resolved

src/configAPIClient.ts Show resolved Hide resolved

src/pre-init-utils.ts Outdated Show resolved Hide resolved

src/sdkRuntimeModels.ts Show resolved Hide resolved

src/sdkRuntimeModels.ts Show resolved Hide resolved

src/sdkRuntimeModels.ts Show resolved Hide resolved

src/sdkRuntimeModels.ts Outdated Show resolved Hide resolved

src/store.ts Outdated Show resolved Hide resolved

test/src/tests-identities-attributes.ts Show resolved Hide resolved

alexs-mparticle changed the base branch from refactor/ts-migration-blackout-2024 to development

February 4, 2025 14:31

alexs-mparticle changed the base branch from development to refactor/ts-migration-blackout-2024

February 4, 2025 14:32

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from 21a3c8c to 6d86697 Compare

February 4, 2025 14:33

alexs-mparticle changed the base branch from refactor/ts-migration-blackout-2024 to development

February 4, 2025 14:34

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from 6d86697 to d327c7e Compare

February 4, 2025 14:36

rmi22186 reviewed

View reviewed changes

test/src/tests-identity.ts Outdated Show resolved Hide resolved

rmi22186 reviewed

View reviewed changes

test/src/tests-identity.ts Outdated Show resolved Hide resolved

alexs-mparticle requested review from rmi22186 and removed request for einsteinx2

February 4, 2025 16:21

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from 9810184 to 42c56ad Compare

February 4, 2025 16:25

rmi22186 reviewed

View reviewed changes

src/sdkRuntimeModels.ts

    
                  getIntegrationAttributes(integrationModuleId: number): IntegrationAttribute;

              }

              // https://go.mparticle.com/work/SQDSDKS-4805

Member

rmi22186 Feb 4, 2025

not sure if this comment needs to be here. not a big deal and can be removed in the next PR

rmi22186 reviewed

View reviewed changes

src/mp-instance.ts Outdated Show resolved Hide resolved

rmi22186 approved these changes

View reviewed changes

alexs-mparticle added the wait to merge label

alexs-mparticle mentioned this pull request

fix: Update new mParticleInstance instantiation #974

Merged

1 task

alexs-mparticle and others added 2 commits

February 5, 2025 13:18


          refactor: Migrate mParticle Instance to TypeScript

949449d


          Update src/mp-instance.ts

c520aa3

Co-authored-by: Robert Ing <rmi22186@gmail.com>

alexs-mparticle force-pushed the refactor/SQDSDKS-4804-mp-instance-ts branch from aa1d95f to c520aa3 Compare

February 5, 2025 18:18

sonarqubecloud bot commented Feb 5, 2025

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

alexs-mparticle merged commit 539ff3d into development

27 of 30 checks passed

alexs-mparticle removed the wait to merge label

Collaborator

mparticle-automation commented Feb 10, 2025

🎉 This PR is included in version 2.32.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

mparticle-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels