fix: Support numbers in vault

src/vault.ts

@@ -1,5 +1,5 @@
 import { Logger } from '@mparticle/web-sdk';
-import { isEmpty } from './utils';
+import { isEmpty, isNumber } from './utils';
 
 export interface IVaultOptions {
     logger?: Logger;
@@ -42,9 +42,14 @@ export abstract class BaseVault<StorableItem> {
      * @param item {StorableItem}
      */
     public store(item: StorableItem): void {
+        let stringifiedItem: string;
         this.contents = item;
 
-        const stringifiedItem = !isEmpty(item) ? JSON.stringify(item) : '';
+        if (isNumber(item)) {
+            stringifiedItem = JSON.stringify(item);
+        } else {
+            stringifiedItem = !isEmpty(item) ? JSON.stringify(item) : '';
+        }
 
         try {
             this.storageObject.setItem(this._storageKey, stringifiedItem);
@@ -97,4 +102,4 @@ export class SessionStorageVault<StorableItem> extends BaseVault<StorableItem> {
     constructor(storageKey: string, options?: IVaultOptions) {
         super(storageKey, window.sessionStorage, options);
     }
-}
+}

test/src/vault.spec.ts

@@ -13,6 +13,9 @@ const testArray: Dictionary<string>[] = [
     { narf: 'poit' },
 ];
 
+const testString: string = 'foo';
+const testNumber: number = 123;
+
 describe('Vault', () => {
     describe('SessionStorageVault', () => {
         afterEach(() => {
@@ -49,6 +52,36 @@ describe('Vault', () => {
                     JSON.stringify(testArray)
                 );
             });
+
+            it('should store a string', () => {
+                const storageKey = 'test-key-store-array';
+
+                const vault = new SessionStorageVault<string>(
+                    storageKey
+                );
+
+                vault.store(testString);
+
+                expect(vault.contents).to.equal(testString);
+                expect(window.sessionStorage.getItem(storageKey)).to.equal(
+                    JSON.stringify(testString)
+                );
+            });
+
+            it('should store a number', () => {
+                const storageKey = 'test-key-store-array';
+
+                const vault = new SessionStorageVault<number>(
+                    storageKey
+                );
+
+                vault.store(testNumber);
+
+                expect(vault.contents).to.equal(testNumber);
+                expect(window.sessionStorage.getItem(storageKey)).to.equal(
+                    JSON.stringify(testNumber)
+                );
+            });
         });
 
         describe('#retrieve', () => {
@@ -168,6 +201,36 @@ describe('Vault', () => {
                     JSON.stringify(testArray)
                 );
             });
+
+            it('should store a string', () => {
+                const storageKey = 'test-key-store-array';
+
+                const vault = new LocalStorageVault<string>(
+                    storageKey
+                );
+
+                vault.store(testString);
+
+                expect(vault.contents).to.equal(testString);
+                expect(window.localStorage.getItem(storageKey)).to.equal(
+                    JSON.stringify(testString)
+                );
+            });
+
+            it('should store a number', () => {
+                const storageKey = 'test-key-store-array';
+
+                const vault = new LocalStorageVault<number>(
+                    storageKey
+                );
+
+                vault.store(testNumber);
+
+                expect(vault.contents).to.equal(testNumber);
+                expect(window.localStorage.getItem(storageKey)).to.equal(
+                    JSON.stringify(testNumber)
+                );
+            });
         });
 
         describe('#retrieve', () => {