feat: Add listeners for signaling when kit is ready #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmi22186
reviewed
Mar 11, 2025
src/forwarders.js
Outdated
| ); | ||
| if (!forwarder.initialized) { | ||
| mpInstance._preInit.kitListeners[forwarder.id] = { | ||
| isInitialized: true, |
Member
There was a problem hiding this comment.
can prob remove
Suggested change
| isInitialized: true, |
rmi22186
reviewed
Mar 11, 2025
src/mp-instance.ts
Outdated
| return {}; | ||
| } | ||
| }; | ||
| // Used by our forwarders |
Member
There was a problem hiding this comment.
Suggested change
| // Used by our forwarders | |
| // addForwarder is called by each individual mp kit | |
| // kitready is called by each individual mp kit | |
| // onKitReady is called by the partner who is importing mparticle |
rmi22186
reviewed
Mar 11, 2025
| } | ||
| }; | ||
| // Used by our forwarders | ||
| this.onKitReady = function(moduleId, callback) { |
Member
There was a problem hiding this comment.
queue this if isInitialized is false
rmi22186
reviewed
Mar 11, 2025
Comment on lines
+1273
to
+1278
| const kitListener = self._preInit.kitListeners[moduleId]; | ||
|
|
||
| if (!kitListener) { | ||
| self.Logger.error('Kit listener not found for moduleId: ' + moduleId); | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I would DRY this with a method so that it's a helper function
Collaborator
Author
There was a problem hiding this comment.
I think that work should be done as part of https://go.mparticle.com/work/SQDSDKS-4475
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)