Skip to content

fix: update architecture checks to use isFabricEnabled in RoktLayoutView iOS #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomson-t merged 2 commits into from
Jul 24, 2025
Merged

fix: update architecture checks to use isFabricEnabled in RoktLayoutView iOS #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daec733
fix: update architecture checks to use isFabricEnabled in RoktLayoutV…
thomson-t Jul 23, 2025
7013b08
Remove unused imports
thomson-t Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions js/rokt/rokt-layout-view.ios.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,11 @@ import {
StyleSheet,
NativeEventEmitter,
NativeModules,
HostComponent,
ViewProps,
NativeModule,
UIManager,
} from 'react-native';
import React, { Component } from 'react';
import { isNewArchitecture } from '../utils/architecture';
import { isFabricEnabled } from '../utils/architecture';
import RoktLayoutNativeComponent from '../codegenSpecs/rokt/RoktLayoutNativeComponent';

const RoktEventManager = NativeModules.RoktEventManager as NativeModule;
Expand Down Expand Up @@ -52,7 +50,7 @@ interface RoktNativeLayoutProps extends ViewProps {

// Use the appropriate component based on architecture
const LayoutNativeComponent = (
isNewArchitecture
isFabricEnabled
? RoktLayoutNativeComponent
: requireNativeComponent<RoktNativeLayoutProps>('RoktLegacyLayout')
) as any;
Expand Down
3 changes: 3 additions & 0 deletions js/utils/architecture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@ import { NativeModules, TurboModuleRegistry, TurboModule } from 'react-native';

declare const global: {
__turboModuleProxy: unknown;
nativeFabricUIManager: unknown;
};

export const isNewArchitecture = global.__turboModuleProxy != null;

export const isFabricEnabled = global.nativeFabricUIManager != null;

/**
* Gets the native module for both old and new architectures
* @param moduleName The name of the module
Expand Down